From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [ANN] Agenda speed up Date: Mon, 28 Aug 2017 16:24:50 +0200 Message-ID: <878ti3srbh.fsf@nicolasgoaziou.fr> References: <87h8wtugst.fsf@nicolasgoaziou.fr> <87o9r0uhl2.fsf@t3610> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmKyD-0003qZ-MR for emacs-orgmode@gnu.org; Mon, 28 Aug 2017 10:24:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmKyC-0003MA-Qc for emacs-orgmode@gnu.org; Mon, 28 Aug 2017 10:24:53 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:57537) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmKyC-0003Lr-Jz for emacs-orgmode@gnu.org; Mon, 28 Aug 2017 10:24:52 -0400 Received: from saiph.selenimh (unknown [IPv6:2a03:a0a0:0:4301::469]) (Authenticated sender: mail@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 04D23C5A73 for ; Mon, 28 Aug 2017 16:24:50 +0200 (CEST) Received: from ngz by saiph.selenimh with local (Exim 4.89) (envelope-from ) id 1dmKyA-0007lN-8v for emacs-orgmode@gnu.org; Mon, 28 Aug 2017 16:24:50 +0200 In-Reply-To: <87o9r0uhl2.fsf@t3610> (Eric S. Fraga's message of "Mon, 28 Aug 2017 11:12:09 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode List Hello, Eric S Fraga writes: > I've compared timings old with new (from git a few minutes ago) by > starting up emacs, instrumenting package org, viewing agenda (defaults > to 1 day), switching to month view and then moving to the following > month: > > Old agenda: > > | org-agenda-list | 3 | 19.770361111 | 6.5901203703 | [...] > New agenda: > > | org-agenda-list | 3 | 29.473988928 | 9.824662976 | How great! I managed to achieve a negative speed up. > | org-agenda-skip | 97251 | 8.0815792529 | 8.310...e-05 | I overlooked `org-agenda-skip', which does nothing fancy on my side. It is indeed called more often... Skipping is actually harder with the cache, because you want to cache everything anyway (or the cache cannot be trusted). > I had to remove a bunch of <%% (...)> items in one of my agenda files as > these gave me error messages about the sexp. Could you show one of the culprits? > Finally, most importantly, the actual items shown in the day view with > the new code are only a subset of those shown with the old view. I > cannot see any pattern in those omitted. There may be more than one pattern involved. Maybe the types involved would help. I updated the "wip-agenda-speedup" branch (rebasing needed). It should now call `org-agenda-skip' less often. Could you try again using that? Thank you for the feedback. Regards, -- Nicolas Goaziou