From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: Bastien Guerry <bzg@gnu.org>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns
Date: Sun, 15 Apr 2018 09:32:22 +0200 [thread overview]
Message-ID: <87o9iklybd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87wox9xmip.fsf@gmail.com> (stardiviner's message of "Sun, 15 Apr 2018 09:54:06 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> About the compilation warnings. I only did "make test". have not do
> compilation test. Do you mean compile whole org-mode project or compile
> a single file ob-clojure.el with [M-x byte-compile-file]? I will include
> this step in my future patch workflow.
make test shows compilation warnings. For extra care, you can also run
"make single".
> I don't know how to replace `-map` and `-contains-p` functions. Is there
> any suggestions?
`-map' -> `mapcar'
`-contains-p' -> `member', `memq', `cl-member' or even `seq-contains',
which is fine for "contrib/".
> BTW, I write some documents on Worg about ob-clojure :ns usage,
> ob-clojure-literate.el and ob-js :session usage etc. But I can't push to
> remote. Here is my steps.
I'm Cc'ing Bastien about it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-04-15 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 12:55 [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns stardiviner
2018-04-14 16:31 ` Nicolas Goaziou
2018-04-15 1:54 ` stardiviner
2018-04-15 7:32 ` Nicolas Goaziou [this message]
2018-04-23 8:30 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9iklybd.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).