From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns
Date: Sat, 14 Apr 2018 18:31:44 +0200 [thread overview]
Message-ID: <87604toikv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zi272rlu.fsf@gmail.com> (stardiviner's message of "Fri, 13 Apr 2018 20:55:25 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> After about 5 times test, And about 4 times review. I decide to PR.
Thank you.
I applied the patches with some substantial changes to commit messages
(often incomplete), removed "subr-x.el" calls (`thread-last' is just
confusing) and fixed compilation warnings.
Please double-check as I might have fumbled in the process.
I didn't change "ob-clojure-literate.el" but there are dangling parens
and whitespace issues to fix. Also, I don't see the need for `dash'
library, but since it's a contrib/ package, I won't insist of it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-04-14 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 12:55 [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns stardiviner
2018-04-14 16:31 ` Nicolas Goaziou [this message]
2018-04-15 1:54 ` stardiviner
2018-04-15 7:32 ` Nicolas Goaziou
2018-04-23 8:30 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87604toikv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).