From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Change: (org-agenda-get-progress) Set type text-property accordingly
Date: Thu, 06 Sep 2018 21:43:19 +0200 [thread overview]
Message-ID: <87o9da76p4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87va7q3uno.fsf@alphapapa.net> (Adam Porter's message of "Fri, 31 Aug 2018 19:53:31 -0500")
Hello,
Adam Porter <adam@alphapapa.net> writes:
> Previously, the "type" text-property was always set to "closed", even
> when an item was actually matched because of its "Clock" or "State"
> line.
>
> Now, the "type" text-property is set according to why the item was
> matched.
>
> Note: it's possible that some code might expect the value to be
> "closed" in all 3 cases, in which case this could cause a minor
> regression, so this change should be carefully considered. However,
> in the long run, it seems like the correct thing to do and a
> worthwhile change to make.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2018-09-06 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 0:53 [PATCH] Change: (org-agenda-get-progress) Set type text-property accordingly Adam Porter
2018-09-06 19:43 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9da76p4.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).