From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Change: (org-agenda-get-progress) Set type text-property accordingly Date: Thu, 06 Sep 2018 21:43:19 +0200 Message-ID: <87o9da76p4.fsf@nicolasgoaziou.fr> References: <87va7q3uno.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fy0Be-0002jx-2f for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 15:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fy0BX-0003cO-SB for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 15:43:28 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43065) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fy0BX-0003Wv-E4 for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 15:43:23 -0400 In-Reply-To: <87va7q3uno.fsf@alphapapa.net> (Adam Porter's message of "Fri, 31 Aug 2018 19:53:31 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Adam Porter Cc: emacs-orgmode@gnu.org Hello, Adam Porter writes: > Previously, the "type" text-property was always set to "closed", even > when an item was actually matched because of its "Clock" or "State" > line. > > Now, the "type" text-property is set according to why the item was > matched. > > Note: it's possible that some code might expect the value to be > "closed" in all 3 cases, in which case this could cause a minor > regression, so this change should be carefully considered. However, > in the long run, it seems like the correct thing to do and a > worthwhile change to make. Applied. Thank you. Regards, -- Nicolas Goaziou