emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matthew Lundin <mdl@imapmail.org>
To: numbchild@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block'
Date: Sun, 31 May 2020 11:47:23 -0500	[thread overview]
Message-ID: <87o8q4t5k4.fsf@fastmail.fm> (raw)
In-Reply-To: <87mu5oby49.fsf@gmail.com>

stardiviner <numbchild@gmail.com> writes:

> I updated the patch commit message.
>
> From b0bdf52a305cb5f9663ee1dc2d08c5de6c7cb602 Mon Sep 17 00:00:00 2001
> From: stardiviner <numbchild@gmail.com>
> Date: Sun, 31 May 2020 10:59:41 +0800
> Subject: [PATCH] fix 5f0a9cca3 missing space
>
> * lisp/ob-core.el (org-babel-demarcate-block): replace wrong newline
> with missing space.
> ---
>  lisp/ob-core.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index e554e3934..79937e517 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -1908,7 +1908,7 @@ (defun org-babel-demarcate-block (&optional arg)
>  			(if (looking-at "^") "" "\n")
>  			indent (if upper-case-p "#+END_SRC\n" "#+end_src\n")
>  			(if arg stars indent) "\n"
> -			indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src\n")
> +			indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src ")
>  			lang
>  			(if (> (length headers) 1)
>  			    (concat " " headers) headers)
> -- 
> 2.26.2
>

I think you also need to replace the newline with a space in the upper
case version.

Matt


  reply	other threads:[~2020-05-31 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30  2:03 [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block' stardiviner
2020-05-30 20:57 ` Berry, Charles via General discussions about Org-mode.
2020-05-31  3:02   ` [PATCH] " stardiviner
2020-05-31  3:07 ` [PATCH v2] " stardiviner
2020-05-31 16:47   ` Matthew Lundin [this message]
2020-06-01  0:43     ` stardiviner
2020-06-01  1:12       ` Matthew Lundin
2020-06-01  7:32         ` [PATCH v3] " stardiviner
2020-06-01 13:50           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8q4t5k4.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).