Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block'

[stardiviner <numbchild@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Matthew Lundin <mdl@imapmail.org> writes:

> stardiviner <numbchild@gmail.com> writes:
>
>> I updated the patch commit message.
>>
>> From b0bdf52a305cb5f9663ee1dc2d08c5de6c7cb602 Mon Sep 17 00:00:00 2001
>> From: stardiviner <numbchild@gmail.com>
>> Date: Sun, 31 May 2020 10:59:41 +0800
>> Subject: [PATCH] fix 5f0a9cca3 missing space
>>
>> * lisp/ob-core.el (org-babel-demarcate-block): replace wrong newline
>> with missing space.
>> ---
>>  lisp/ob-core.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
>> index e554e3934..79937e517 100644
>> --- a/lisp/ob-core.el
>> +++ b/lisp/ob-core.el
>> @@ -1908,7 +1908,7 @@ (defun org-babel-demarcate-block (&optional arg)
>>  			(if (looking-at "^") "" "\n")
>>  			indent (if upper-case-p "#+END_SRC\n" "#+end_src\n")
>>  			(if arg stars indent) "\n"
>> -			indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src\n")
>> +			indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src ")
>>  			lang
>>  			(if (> (length headers) 1)
>>  			    (concat " " headers) headers)
>> -- 
>> 2.26.2
>>
>
> I think you also need to replace the newline with a space in the upper
> case version.
>

Supposed there is \n after #+end_src. I also checked the original version before
that change commit. The original has an newline. I write patch by comparing
before and after (side by side).

- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7UT0kUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsOt0ggAtPk/dBaarsrRZOLJaN3SUtMeeIUM
BVdY5194hxKVYSxGtvAZDEi4MimfUgBzuXfaytYlVDeBxd1ShBbaoRNecqzlvaLm
qUAvI3S1ALJKfE4NKZrGwmZAbYdSE1OlJrhNz5IZ5xuJRWIz/ssJyVNhXbwwXy5o
QIbKxdzFdQ1g1iEYJOJS6U7yv2glmLkjgqmosMmFoJCA9Qrup898drdeOqwtUM9n
dmy5uehZonZ0bQpyr6Y09jrWj9fsDD53noZH2K1J2LeHYtf5TMrL+mxMRBSuK8SP
BgfwPqz9mYh1/YQzgYfB0s+J/zT1oBzD08WHHmqxbtM0sOc4ixkv7xszIg==
=r+5b
-----END PGP SIGNATURE-----