From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [DISCUSSION] Sorting strings in Org mode vs. system locale
Date: Sat, 11 May 2024 09:38:34 +0000 [thread overview]
Message-ID: <87o79cvgbp.fsf@localhost> (raw)
In-Reply-To: <v1dlv1$sl7$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
>>
>>> I consider the following as a kind of graceful degradation
>>>
>>> (defun org-sort-function-fallback-downcase
>>> (a b &optional LOCALE IGNORE-CASE)
>>> (if ignore-case
>>> (string-collate-lessp (downcase a) (downcase b) locale ignore-case)
>>> (string-collate-lessp a b locale ignore-case)))
>>
>> It is indeed better than `org-sort-function-downcase'.
>
> `compare-strings' with upcase conversion under the hood may be an
> alternative.
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=413192698
I replaced the two fallback variants with #'string< and custom downcase
function with a single fallback that uses `compare-strings'.
Closed.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-05-11 9:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 20:15 test-org-table/sort-lines: Failing test on macOS Rudolf Adamkovič
2022-10-07 12:04 ` Max Nikulin
2022-10-08 5:25 ` Ihor Radchenko
2022-10-08 14:27 ` Max Nikulin
2022-10-09 3:59 ` Ihor Radchenko
2022-10-09 15:38 ` Rudolf Adamkovič
2022-10-09 16:53 ` Max Nikulin
2022-10-10 22:25 ` Rudolf Adamkovič
2022-10-12 16:09 ` Max Nikulin
2022-11-15 4:10 ` Ihor Radchenko
2022-11-20 4:18 ` Ihor Radchenko
2022-11-20 8:00 ` Max Nikulin
2022-11-21 3:15 ` Ihor Radchenko
2022-11-21 16:48 ` Max Nikulin
2022-11-22 1:14 ` Ihor Radchenko
2022-11-22 16:01 ` Max Nikulin
2022-11-23 10:37 ` Ihor Radchenko
2022-11-23 15:27 ` Max Nikulin
2022-11-23 17:01 ` Max Nikulin
2022-11-26 2:05 ` Ihor Radchenko
2022-11-29 16:40 ` Max Nikulin
2024-04-03 11:40 ` [DISCUSSION] Sorting strings in Org mode vs. system locale (was: test-org-table/sort-lines: Failing test on macOS) Ihor Radchenko
2024-05-05 11:59 ` Ihor Radchenko
2024-05-07 11:06 ` [DISCUSSION] Sorting strings in Org mode vs. system locale Max Nikulin
2024-05-07 13:09 ` Ihor Radchenko
2024-05-07 16:47 ` Max Nikulin
2024-05-11 9:38 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o79cvgbp.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).