From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing
Date: Sat, 28 Jul 2012 08:41:02 +0200 [thread overview]
Message-ID: <87mx2ks801.fsf@gnu.org> (raw)
In-Reply-To: <87sjcco2bo.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 28 Jul 2012 07:57:15 +0200")
Achim Gratz <Stromeko@nexgo.de> writes:
> Kyle Machulis writes:
>> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
>> starts with
>>
>> - Move org-element.el from contrib/lisp to lisp/.
>>
>> However, it looks like org-element.el just got deleted, not moved.
>> This causes much badness when trying to rebuild.
>
> Thanks for reporting, it seems Bastien missed a 'git add
> lisp/org-element.el' before doing this commit
Indeed. Thanks for fixing this!
> (and broke a few other
> things with additional changes in the same commit). I don't know if the
> changes in org.el were intended to go live since there is no changelog
> entry for those.
There is a general ChangeLog:
Also move chunks of declarations and require statements to
get rid of compiler warnings.
> If not, they will have to be reverted/changed
> seperately but for now things compile and test cleanly again.
I opened a can of wo^W^Wcompiler warnings while moving org-element.el
to core: the way org.el requires libraries or those libraries require
'org is confusing, and there is still room for simplification. Let's
do this incrementally.
--
Bastien
prev parent reply other threads:[~2012-07-28 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 3:43 [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing Kyle Machulis
2012-07-28 5:57 ` Achim Gratz
2012-07-28 6:41 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx2ks801.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).