From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing Date: Sat, 28 Jul 2012 08:41:02 +0200 Message-ID: <87mx2ks801.fsf@gnu.org> References: <87sjcco2bo.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:43644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv0hR-0006pJ-Br for emacs-orgmode@gnu.org; Sat, 28 Jul 2012 02:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sv0hQ-0003AV-81 for emacs-orgmode@gnu.org; Sat, 28 Jul 2012 02:40:29 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:57480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv0hQ-0003AR-1I for emacs-orgmode@gnu.org; Sat, 28 Jul 2012 02:40:28 -0400 Received: by wibhm2 with SMTP id hm2so1154594wib.0 for ; Fri, 27 Jul 2012 23:40:26 -0700 (PDT) In-Reply-To: <87sjcco2bo.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 28 Jul 2012 07:57:15 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Kyle Machulis writes: >> In commit abbea596111611a945d73783b3e8790e76599740, the commit message >> starts with >> >> - Move org-element.el from contrib/lisp to lisp/. >> >> However, it looks like org-element.el just got deleted, not moved. >> This causes much badness when trying to rebuild. > > Thanks for reporting, it seems Bastien missed a 'git add > lisp/org-element.el' before doing this commit Indeed. Thanks for fixing this! > (and broke a few other > things with additional changes in the same commit). I don't know if the > changes in org.el were intended to go live since there is no changelog > entry for those. There is a general ChangeLog: Also move chunks of declarations and require statements to get rid of compiler warnings. > If not, they will have to be reverted/changed > seperately but for now things compile and test cleanly again. I opened a can of wo^W^Wcompiler warnings while moving org-element.el to core: the way org.el requires libraries or those libraries require 'org is confusing, and there is still room for simplification. Let's do this incrementally. -- Bastien