[Bug] marking repeating task done destroys property/logbook drawers

[Bug] marking repeating task done destroys property/logbook drawers

[Matt Lundin]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

When I mark a repeating task done (with the settings in the minimal.el
file below), org mangles the :LOGBOOK: and :PROPERTY: drawers when
trying to insert a :LAST_REPEAT: property.

Here are the steps to reproduce consistently:

1. emacs -Q -l ~/minimal.el 

where minimal.el contains...


[-- Attachment #2: minimal.el --]
[-- Type: application/emacs-lisp, Size: 174 bytes --]

[-- Attachment #3: Type: text/plain, Size: 1586 bytes --]


2. Open an org-file containing the following entry.

--8<---------------cut here---------------start------------->8---
* TODO Repeating task
  SCHEDULED: <2014-03-02 Sun .+2w>
  :LOGBOOK:
  - State "DONE"       from "NOW"        [2014-02-23 Sun 08:39]
  CLOCK: [2014-02-23 Sun 08:26]--[2014-02-23 Sun 08:39] =>  0:13
  - State "DONE"       from "STARTED"    [2014-01-28 Tue 20:17]
  :END:
  :PROPERTIES:
  :LAST_REPEAT: [2014-02-23 Sun 08:39]
  :END:
--8<---------------cut here---------------end--------------->8---

3. Mark the item DONE. 

Voilà... note the empty property drawer, the duplicate logbook drawers,
and the misplaced :LAST_REPEAT:

--8<---------------cut here---------------start------------->8---
* TODO Repeating task
  SCHEDULED: <2014-03-17 Mon .+2w>
  :LOGBOOK:
  - State "DONE"       from "TODO"       [2014-03-03 Mon 22:11]
  :END:
  :LAST_REPEAT: [2014-03-03 Mon 22:11]  :LOGBOOK:
  - State "DONE"       from "NOW"        [2014-02-23 Sun 08:39]
  CLOCK: [2014-02-23 Sun 08:26]--[2014-02-23 Sun 08:39] =>  0:13
  - State "DONE"       from "STARTED"    [2014-01-28 Tue 20:17]
  :END:
  :PROPERTIES:

  :END:
--8<---------------cut here---------------end--------------->8---

I am using...

 - Emacs version: 24.3.1
 - Org-mode version: 8.2.5h

...on Arch Linux.

Running edebug suggested that org-entry-put (which is invoked by
org-auto-repeat-maybe) places the :LAST_REPEAT: in the wrong place.
However, I couldn't discern why, since invocations of org-entry-put
otherwise seem to work fine.

Thanks,
Matt

Re: [Bug] marking repeating task done destroys property/logbook drawers

[Karl Voit]

* Matt Lundin <mdl@imapmail.org> wrote:
>
> When I mark a repeating task done (with the settings in the minimal.el
> file below), org mangles the :LOGBOOK: and :PROPERTY: drawers when
> trying to insert a :LAST_REPEAT: property.

I can confirm this bug at my side.[1]

  1. https://github.com/novoid/dot-emacs
-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

Re: [Bug] marking repeating task done destroys property/logbook drawers

[Bastien]

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> When I mark a repeating task done (with the settings in the minimal.el
> file below), org mangles the :LOGBOOK: and :PROPERTY: drawers when
> trying to insert a :LAST_REPEAT: property.

I can't reproduce this.  Karl can, so there is something weird here.

> I am using...
>
>  - Emacs version: 24.3.1
>  - Org-mode version: 8.2.5h

Can you use M-x org-version RET (or C-u M-x org-version RET to insert
the output in your mail) ?

> Running edebug suggested that org-entry-put (which is invoked by
> org-auto-repeat-maybe) places the :LAST_REPEAT: in the wrong place.
> However, I couldn't discern why, since invocations of org-entry-put
> otherwise seem to work fine.

Thanks for any further investigation, it's hard to know what can be
wrong without being to reproduce this.

-- 
 Bastien

Re: [Bug] marking repeating task done destroys property/logbook drawers

[Matt Lundin]

Hi Bastien,

Bastien <bzg@gnu.org> writes:

> Hi Matt,
>
> Matt Lundin <mdl@imapmail.org> writes:
>
>> When I mark a repeating task done (with the settings in the minimal.el
>> file below), org mangles the :LOGBOOK: and :PROPERTY: drawers when
>> trying to insert a :LAST_REPEAT: property.
>
> I can't reproduce this.  Karl can, so there is something weird here.
>
>> I am using...
>>
>>  - Emacs version: 24.3.1
>>  - Org-mode version: 8.2.5h
>
> Can you use M-x org-version RET (or C-u M-x org-version RET to insert
> the output in your mail) ?
>
>> Running edebug suggested that org-entry-put (which is invoked by
>> org-auto-repeat-maybe) places the :LAST_REPEAT: in the wrong place.
>> However, I couldn't discern why, since invocations of org-entry-put
>> otherwise seem to work fine.
>
> Thanks for any further investigation, it's hard to know what can be
> wrong without being to reproduce this.

This was a problem with org-element's cache. It was solved with the
following commit:

a8568372ad8bba841af7f7d1fdf9b64d38426c3a

Here's the original post of the thread containing the solution:

http://permalink.gmane.org/gmane.emacs.orgmode/83015

Matt

Re: [Bug] marking repeating task done destroys property/logbook drawers

[Bastien]

Matt Lundin <mdl@imapmail.org> writes:

> This was a problem with org-element's cache.

Okay, thanks for following up!

-- 
 Bastien