Re: [PATCH v2] ob-vala.el: Add Vala support to Babel

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Christian Garbs <mitch@cgarbs.de> writes:

> * ob-vala.el: Add support for the Vala language to Babel.
> ---
>  lisp/ob-vala.el | 122 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 122 insertions(+)
>  create mode 100644 lisp/ob-vala.el
>
> diff --git a/lisp/ob-vala.el b/lisp/ob-vala.el
> new file mode 100644
> index 0000000..0375265
> --- /dev/null
> +++ b/lisp/ob-vala.el
> @@ -0,0 +1,122 @@
> +;;; ob-vala.el --- org-babel functions for Vala evaluation

Babel functions for Vala evaluation

Also, could you use lexical binding, i.e., add "-*- lexical-binding:
t; -*-" on the first line of the file and check byte-compilation doesn't
complain.

> +(defcustom org-babel-vala-compiler "valac"
> +  "Command used to compile a C source code file into an executable.
> +May be either a command in the path, like `valac'

like \"valac\"

> +or an absolute path name, like `/usr/local/bin/valac'.

an absolute file name, like \"/usr/local/bin/valac\".

> +Parameters may be used like this: `valac -v'"

like this: \"valac -c\""

> +  :group 'org-babel
> +  :version "24.3"
> +  :type 'string)

Some keywords are missing:

  :version "26.1"
  :package-version '(Org . "9.1")

Barring the suggestions above, your patch looks good. I think we can
apply it as soon as the FSF process is complete.

Thank you!

Regards,

-- 
Nicolas Goaziou