From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Wed, 02 Aug 2017 00:03:50 +0200 [thread overview]
Message-ID: <87ini7q721.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20170801212052.lc64vzvuluglctqq@cgarbs.de> (Christian Garbs's message of "Tue, 1 Aug 2017 23:20:52 +0200")
Hello,
Christian Garbs <mitch@cgarbs.de> writes:
> Hello and sorry for the wait!
No problem.
> Looking at the other defcustoms, is the current wording ok?
It is.
> Some of your proposed changes apply to ob-C.el as well. I could
> prepare a different patch for that (under which topic?),
Depending on the size of the changes, it could be "Tiny changes", "Small
refactoring"...
> but I am not confident that I could test the changes appropriately.
> I don't have proper C/C++/D org files handy that would cover all cases
> (eg. header arguments).
ob-C.el has a couple of tests (BTW, would you want to write some for
"ob-vala.el"?).
> PS: My FSF paperwork is complete.
I overlooked this information. These are great news. I'll push your
patch once updated (see my other mail).
Could you provide an ORG-NEWS entry about the new file?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-08-01 22:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 20:09 Babel support for Vala Christian Garbs
2017-07-10 9:03 ` Nicolas Goaziou
2017-07-10 17:54 ` Christian Garbs
2017-07-11 8:10 ` Nicolas Goaziou
2017-07-13 21:42 ` Christian Garbs
2017-07-14 8:30 ` Nicolas Goaziou
2017-07-14 19:43 ` [PATCH] ob-vala.el: Add Vala support to Babel Christian Garbs
2017-07-23 9:05 ` Nicolas Goaziou
2017-07-31 22:04 ` [PATCH v2] " Christian Garbs
2017-08-01 21:59 ` Nicolas Goaziou
2017-07-31 22:04 ` [PATCH v3] " Christian Garbs
2017-08-07 9:41 ` Nicolas Goaziou
2017-08-01 21:20 ` [PATCH] " Christian Garbs
2017-08-01 22:03 ` Nicolas Goaziou [this message]
2017-08-02 20:24 ` Christian Garbs
2017-08-03 10:49 ` Nicolas Goaziou
2017-08-05 19:53 ` Christian Garbs
2017-08-06 0:22 ` Nicolas Goaziou
2017-08-06 10:06 ` Christian Garbs
2017-08-07 9:52 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ini7q721.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mitch@cgarbs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).