From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Wed, 02 Aug 2017 00:03:50 +0200
Message-ID: <87ini7q721.fsf@nicolasgoaziou.fr>
References: <87fudze7y4.fsf@nicolasgoaziou.fr>
	<1500061387-3353-1-git-send-email-mitch@cgarbs.de>
	<87379no75t.fsf@nicolasgoaziou.fr>
	<20170801212052.lc64vzvuluglctqq@cgarbs.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcfGb-0006P2-1Q
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:03:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcfGa-0006A0-1X
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:03:53 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:32826)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dcfGZ-00069i-RF
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 18:03:51 -0400
In-Reply-To: <20170801212052.lc64vzvuluglctqq@cgarbs.de> (Christian Garbs's
	message of "Tue, 1 Aug 2017 23:20:52 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org

Hello,

Christian Garbs <mitch@cgarbs.de> writes:

> Hello and sorry for the wait!

No problem.

> Looking at the other defcustoms, is the current wording ok?

It is.

> Some of your proposed changes apply to ob-C.el as well.  I could
> prepare a different patch for that (under which topic?),

Depending on the size of the changes, it could be "Tiny changes", "Small
refactoring"...

> but I am not confident that I could test the changes appropriately.
> I don't have proper C/C++/D org files handy that would cover all cases
> (eg. header arguments).

ob-C.el has a couple of tests (BTW, would you want to write some for
"ob-vala.el"?).

> PS: My FSF paperwork is complete.

I overlooked this information. These are great news. I'll push your
patch once updated (see my other mail).

Could you provide an ORG-NEWS entry about the new file?

Regards,

-- 
Nicolas Goaziou