adding a footnote munches newlines at the end of a section

adding a footnote munches newlines at the end of a section

[Eric Abrahamsen]

I use `org-footnote-action' (C-c C-x f) to add a footnote, and don't
have any "org-footnote-section" set, so it adds them at the end of the
current subtree. This progressively eats up newlines, so that if I add
two footnotes in a row, it intrudes on the headline of the next section:

--8<---------------cut here---------------start------------->8---
[fn:31] 字里的飞白

[fn:32] sdfdsfsdf

[fn:33] * Two

  They'd been going somewhere called Hailing[fn:4], a largish town,
  but Qin Shanyuan decided to stop here at the village of Zhaxia.
--8<---------------cut here---------------end--------------->8---

Obviously "* Two" is actually meant to be on its own line, forming a new
headline.

This appears to be a problem with
`org-footnote-goto-local-insertion-point', or with whatever function
comes afterwards to add the actual footnote label. I guess not enough
newlines are added. Is this reproducible elsewhere?

Thanks,
Eric

-- 
GNU Emacs 24.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.24.9)
 of 2012-01-26 on pellet
Org-mode version 7.8.03 (release_7.8.03.285.g646b3)

Re: adding a footnote munches newlines at the end of a section

[Achim Gratz]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> This appears to be a problem with
> `org-footnote-goto-local-insertion-point', or with whatever function
> comes afterwards to add the actual footnote label. I guess not enough
> newlines are added. Is this reproducible elsewhere?

Your recipe leads to the same symptoms here.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: adding a footnote munches newlines at the end of a section

[Nicolas Goaziou]

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I use `org-footnote-action' (C-c C-x f) to add a footnote, and don't
> have any "org-footnote-section" set, so it adds them at the end of the
> current subtree. This progressively eats up newlines, so that if I add
> two footnotes in a row, it intrudes on the headline of the next
> section.

I have pushed a fix for that problem, and another one related to the
absence of org-footnote-section (normalizing footnotes would put them
all in the same section).

Does it work for you?


Regards,

-- 
Nicolas Goaziou

Re: adding a footnote munches newlines at the end of a section

[Eric Abrahamsen]

On Thu, Feb 02 2012, Nicolas Goaziou wrote:

> Hello,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I use `org-footnote-action' (C-c C-x f) to add a footnote, and don't
>> have any "org-footnote-section" set, so it adds them at the end of the
>> current subtree. This progressively eats up newlines, so that if I add
>> two footnotes in a row, it intrudes on the headline of the next
>> section.
>
> I have pushed a fix for that problem, and another one related to the
> absence of org-footnote-section (normalizing footnotes would put them
> all in the same section).
>
> Does it work for you?

Thanks for your attention, Nicolas, but I'm still seeing the same
behavior. I went pawing through the code to see if I could track down
the exact spot where it goes wrong, and can only come up with what is
now line 550 in "org-footnote.el". Shouldn't the call to `insert'
include a trailing newline?

Thanks again,
Eric

-- 
GNU Emacs 24.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.24.9)
 of 2012-01-26 on pellet
Org-mode version 7.8.03 (release_7.8.03.293.g36cc)

Re: adding a footnote munches newlines at the end of a section

[Nicolas Goaziou]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Thanks for your attention, Nicolas, but I'm still seeing the same
> behavior. I went pawing through the code to see if I could track down
> the exact spot where it goes wrong, and can only come up with what is
> now line 550 in "org-footnote.el". Shouldn't the call to `insert'
> include a trailing newline?

Could you try reloading Org, or even Emacs and try again? I'm asking
that before I cannot reproduce the problem anymore since the patches.

Regards,

-- 
Nicolas Goaziou

Re: adding a footnote munches newlines at the end of a section

[Eric Abrahamsen]

On Thu, Feb 02 2012, Nicolas Goaziou wrote:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Thanks for your attention, Nicolas, but I'm still seeing the same
>> behavior. I went pawing through the code to see if I could track down
>> the exact spot where it goes wrong, and can only come up with what is
>> now line 550 in "org-footnote.el". Shouldn't the call to `insert'
>> include a trailing newline?
>
> Could you try reloading Org, or even Emacs and try again? I'm asking
> that before I cannot reproduce the problem anymore since the patches.

Nope, it's still doing it… I killed emacs, cleaned and re-make'd org,
and it's still behaving the same on restart. Sorry! I still don't see
where the additional newline would come from, if not at the end of
`org-footnote-create-definition' (though obviously just tacking an extra
newline on there would leave point in the wrong place). Anyway, maybe
someone else will test…

Thanks,
Eric

-- 
GNU Emacs 24.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.24.9)
 of 2012-01-26 on pellet
Org-mode version 7.8.03 (release_7.8.03.293.g36cc)

Re: adding a footnote munches newlines at the end of a section

[Nicolas Goaziou]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Nope, it's still doing it… I killed emacs, cleaned and re-make'd org,
> and it's still behaving the same on restart. Sorry! I still don't see
> where the additional newline would come from, if not at the end of
> `org-footnote-create-definition' (though obviously just tacking an extra
> newline on there would leave point in the wrong place). Anyway, maybe
> someone else will test…

You're probably right about the location of the problem.  Though, I'd
like to understand what is wrong. Could you send me an ECM to help me
reproduce the problem?


Regards,

-- 
Nicolas Goaziou

Re: adding a footnote munches newlines at the end of a section

[Achim Gratz]

Nicolas Goaziou <n.goaziou@gmail.com> writes:
> You're probably right about the location of the problem.  Though, I'd
> like to understand what is wrong. Could you send me an ECM to help me
> reproduce the problem?

This orgmode document:
--8<---------------cut here---------------start------------->8---
* Stuff

Make org-footnote-section a local variable and set it nil.  Then add a
footnote with the cursor after this sentence.

* More stuff

This ist just to show how it gets encroached by the footnote markers.
--8<---------------cut here---------------end--------------->8---


Will look like that:
--8<---------------cut here---------------start------------->8---
* Stuff

Make org-footnote-section a local variable and set it nil.  Then add a
footnote with the cursor after this sentence.[fn:1] [fn:2][fn:3]

[fn:1] 

[fn:2] * More stuff

This ist just to show how it gets encroached by the footnote markers.

[fn:3] 
--8<---------------cut here---------------end--------------->8---

The result is actually the same before and after your commit b032a6.


HTH,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: adding a footnote munches newlines at the end of a section

[Nicolas Goaziou]

Hello,

Achim Gratz <Stromeko@nexgo.de> writes:

> The result is actually the same before and after your commit b032a6.

Yes. I had forgotten that my setup included a non-nil
`org-footnote-auto-adjust'. I couldn't see the bug. The good thing is
that I slayed two innocent bugs in the process.

I think this problem should be fixed. Blank lines handling is a bit
tricky with footnotes, but it should be better now.

Thanks for the ECM.


Regards,

-- 
Nicolas Goaziou

Re: adding a footnote munches newlines at the end of a section

[Achim Gratz]

Nicolas Goaziou <n.goaziou@gmail.com> writes:
> I think this problem should be fixed. Blank lines handling is a bit
> tricky with footnotes, but it should be better now.

I confirm the fix.  Thank you.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: adding a footnote munches newlines at the end of a section

[Eric Abrahamsen]

On Fri, Feb 03 2012, Achim Gratz wrote:

> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>> I think this problem should be fixed. Blank lines handling is a bit
>> tricky with footnotes, but it should be better now.
>
> I confirm the fix.  Thank you.

Me too, and likewise for the missing footnotes in ODT.

Thanks very much!

Eric

-- 
GNU Emacs 24.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.24.9)
 of 2012-01-26 on pellet
Org-mode version 7.8.03 (release_7.8.03.300.g9b820)