From: Eric Schulte <eric.schulte@gmx.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Bug] Tests for experimental org-features should expect to fail if not activated by the user
Date: Wed, 29 Feb 2012 09:18:33 -0700 [thread overview]
Message-ID: <87linlbokm.fsf@gmx.com> (raw)
In-Reply-To: <87ipit5onv.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 26 Feb 2012 21:24:04 +0100")
Moving forward on this point, many of the existing tests explicitly
`require' new Org-mode functionality (mainly language support for
testing code blocks execution). I do not think that tests should ever
be activating new packages changing a users global environment.
For this reason I have just pushed up a commit which changes all
(require 'org-foo)
to
(unless (featurep 'org-foo)
(signal 'missing-test-dependency "Org support for doing foo."))
so that those tests simple aren't run on the users system. Please let
me know if anyone thinks this is a mistake and we can discuss. The only
drawback I see is that batch-mode scripts will have to explicitly
activate the features which they would like to test, by evaluating forms
like (require 'org-foo) before the call to the test suite -- and I would
argue that being explicit about such things is a benefit.
Cheers,
Achim Gratz <Stromeko@nexgo.de> writes:
> Tests for experimental org features (e.g. from contrib/ ) should expect
> to fail when the user has not configured their inclusion into the
> current setup. In other words, things like "(require org-element)"
> should not break the test run, but instead just note that this test has
> failed expectedly and continue testing.
>
>
> Regards,
> Achim.
--
Eric Schulte
http://cs.unm.edu/~eschulte/
next prev parent reply other threads:[~2012-02-29 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 20:24 [Bug] Tests for experimental org-features should expect to fail if not activated by the user Achim Gratz
2012-02-29 16:18 ` Eric Schulte [this message]
2012-02-29 20:07 ` Achim Gratz
2012-02-29 20:52 ` Eric Schulte
2012-02-29 21:02 ` Achim Gratz
2012-03-01 21:18 ` Achim Gratz
2012-03-02 14:15 ` Nicolas Goaziou
2012-03-02 17:38 ` Achim Gratz
2012-03-03 17:28 ` Achim Gratz
2012-03-03 21:50 ` Nicolas Goaziou
2012-03-04 9:59 ` Achim Gratz
2012-03-04 13:42 ` Nicolas Goaziou
2012-03-04 14:17 ` Achim Gratz
2012-03-04 15:46 ` Nicolas Goaziou
2012-03-04 17:04 ` Achim Gratz
2012-03-03 22:59 ` Sebastien Vauban
2012-03-04 9:39 ` Achim Gratz
2012-03-03 17:21 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87linlbokm.fsf@gmx.com \
--to=eric.schulte@gmx.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).