From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [Bug] Tests for experimental org-features should expect to fail if not activated by the user
Date: Wed, 29 Feb 2012 21:07:16 +0100 [thread overview]
Message-ID: <87hay9z9mz.fsf@Rainer.invalid> (raw)
In-Reply-To: 87linlbokm.fsf@gmx.com
Eric Schulte <eric.schulte@gmx.com> writes:
> Moving forward on this point, many of the existing tests explicitly
> `require' new Org-mode functionality (mainly language support for
> testing code blocks execution). I do not think that tests should ever
> be activating new packages changing a users global environment.
Thanks.
I've had to deactivate the inclusion of ./testing/lisp/contrib into the
test flow due to a recent removal of said directory by Nicolas (he's
probably doing that patch himself) and now get this:
lisp/org-mode> make test-dirty |& grep failed
failed 5/109 ob-exp/export-from-a-temp-buffer
failed 17/109 org-missing-dependency/test-ob-C
failed 18/109 org-missing-dependency/test-ob-R
failed 19/109 org-missing-dependency/test-ob-awk
failed 20/109 org-missing-dependency/test-ob-fortran
failed 21/109 org-missing-dependency/test-ob-lilypond
failed 22/109 org-missing-dependency/test-ob-maxima
failed 23/109 org-missing-dependency/test-ob-octave
failed 24/109 org-missing-dependency/test-ob-python
failed 25/109 org-missing-dependency/test-org-element
failed 26/109 org-missing-dependency/test-org-export
This is expected, as my local configuration doesn't have any of these
packages activated.
lisp/org-mode> make test-dirty | & grep FAILED
FAILED 27/109 test-ob-exp/org-babel-exp-src-blocks/w-no-file
FAILED 62/109 test-org-babel/get-src-block-info-body
FAILED 63/109 test-org-babel/get-src-block-info-language
FAILED 64/109 test-org-babel/get-src-block-info-tangle
This is unexpected and I don't really see where they are coming from.
The backtrace always starts at (regexp-quote org-test-file-ob-anchor).
> For this reason I have just pushed up a commit which changes all
>
> (require 'org-foo)
>
> to
>
> (unless (featurep 'org-foo)
> (signal 'missing-test-dependency "Org support for doing foo."))
>
> so that those tests simple aren't run on the users system. Please let
> me know if anyone thinks this is a mistake and we can discuss. The only
> drawback I see is that batch-mode scripts will have to explicitly
> activate the features which they would like to test, by evaluating forms
> like (require 'org-foo) before the call to the test suite -- and I would
> argue that being explicit about such things is a benefit.
Well, currently all testing runs under my user settings, which is not
ideal for testing anyway. I suppose it would not be difficult to just
inject a different (minimal) startup file specifically for testing to
separate these issues.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada
next prev parent reply other threads:[~2012-02-29 20:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 20:24 [Bug] Tests for experimental org-features should expect to fail if not activated by the user Achim Gratz
2012-02-29 16:18 ` Eric Schulte
2012-02-29 20:07 ` Achim Gratz [this message]
2012-02-29 20:52 ` Eric Schulte
2012-02-29 21:02 ` Achim Gratz
2012-03-01 21:18 ` Achim Gratz
2012-03-02 14:15 ` Nicolas Goaziou
2012-03-02 17:38 ` Achim Gratz
2012-03-03 17:28 ` Achim Gratz
2012-03-03 21:50 ` Nicolas Goaziou
2012-03-04 9:59 ` Achim Gratz
2012-03-04 13:42 ` Nicolas Goaziou
2012-03-04 14:17 ` Achim Gratz
2012-03-04 15:46 ` Nicolas Goaziou
2012-03-04 17:04 ` Achim Gratz
2012-03-03 22:59 ` Sebastien Vauban
2012-03-04 9:39 ` Achim Gratz
2012-03-03 17:21 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hay9z9mz.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).