emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Maxim Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-goto slows down org-set-property
Date: Sun, 11 Jul 2021 19:49:08 +0800	[thread overview]
Message-ID: <87lf6dul3f.fsf@localhost> (raw)
In-Reply-To: <scedec$2g0$1@ciao.gmane.io>

Maxim Nikulin <manikulin@gmail.com> writes:

> It seems, it is better to drop org-refile-cache completely. It has some 
> design problems making it rather fragile. At the same time a patch can 
> be applied that improves performance of `org-refile-get-targets' by a 
> factor of at least 2 for (org-refile-use-outline-path 'file).

I tend agree. I got rid of org-refile-cache some time ago in favour of
org-ql. The performance is much better subjectively, which indicates
that alternative caching mechanisms could be much better.

Your test on my 12M chars 18k headings org file (Emacs master, Org mode
master). I cannot use org-set-property even without org-refile-cache :(
 
#+RESULTS[e3fd8ffd9dd1a1d1cb8cf2ab3927bf647e944dd8]:
| 9.4.6                  |                    |   |                    |
| nm-tst                 | 13.638543295000002 | 4 | 1.9903503830000204 |
| org-refile-get-targets |        5.355179174 | 2 |   0.97954138099999 |
| nm-tst                 |       22.599429478 | 4 | 2.0785714209999924 |
| org-refile-cache-clear |        0.003903494 | 0 |                0.0 |
| nm-tst                 |       13.969909913 | 4 |   2.06943181500003 |

Best,
Ihor



  reply	other threads:[~2021-07-11 11:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 15:47 [BUG] org-goto slows down org-set-property Maxim Nikulin
2021-07-11  9:25 ` Maxim Nikulin
2021-07-11 11:49   ` Ihor Radchenko [this message]
2021-07-11 12:55     ` Maxim Nikulin
2021-07-11 14:20       ` Ihor Radchenko
2021-07-11 15:07         ` Maxim Nikulin
2021-07-11 16:00           ` Ihor Radchenko
2021-07-12 14:59             ` Maxim Nikulin
2021-07-13 14:21               ` John Kitchin
2024-07-07 12:38   ` Ihor Radchenko
2024-10-13 11:45 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf6dul3f.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).