From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-goto slows down org-set-property
Date: Sun, 11 Jul 2021 16:25:30 +0700 [thread overview]
Message-ID: <scedec$2g0$1@ciao.gmane.io> (raw)
In-Reply-To: <sccff7$ers$1@ciao.gmane.io>
On 10/07/2021 22:47, Maxim Nikulin wrote:
> It is rather annoying that C-c C-x p `org-set-property' may be quite
> slow if a file is large enough. (I do not consider it huge however.)
> There is noticeable delay before the prompt for property name appears in
> minibuffer. Accidentally I have noticed that sometimes it is fast.
>
> Problem appears after first jump using C-u C-c C-j `org-goto'. Actually
> a jump is not required, it is enough to get jump (refile) targets.
It is strange. Merely 3500 markers created by org-refile-cache in 2.2Mb
file ruin performance of regexps in that buffer. I would expect either
no influence of markers at all since search is a read-only operation or
some negligible penalty proportional to fraction of markers in relation
to total amount of characters.
Look at the numbers for nm-test that is just some regexp searches from
`org-buffer-property-keys'. Performance is restored after clearing of
the cache.
#+begin_src elisp
(defun nm-tst ()
(org-with-wide-buffer
(goto-char (point-min))
(while (re-search-forward org-property-start-re nil t)
(org-get-property-block)
(outline-next-heading))
nil))
(org-refile-cache-clear)
(let ((org-refile-targets '((nil :maxlevel . 6)))
(org-refile-use-outline-path 'file)
(org-refile-use-cache t)
(iters 10))
(cons
(list (org-version))
(mapcar (lambda (f)
(append (list f) (benchmark-run iters (funcall f))))
(list #'nm-tst ; #'org-buffer-property-keys
#'org-refile-get-targets
#'nm-tst ; #'org-buffer-property-keys
#'org-refile-cache-clear
#'nm-tst))))
#+end_src
#+RESULTS:
| 9.4.6 | | | |
| nm-tst | 0.044981942 | 0 | 0.0 |
| org-refile-get-targets | 1.748572638 | 8 | 0.3876601379999993 |
| nm-tst | 0.393022201 | 0 | 0.0 |
| org-refile-cache-clear | 0.001787078 | 0 | 0.0 |
| nm-tst | 0.035731803 | 0 | 0.0 |
It seems, it is better to drop org-refile-cache completely. It has some
design problems making it rather fragile. At the same time a patch can
be applied that improves performance of `org-refile-get-targets' by a
factor of at least 2 for (org-refile-use-outline-path 'file).
Emacs-26.3
next prev parent reply other threads:[~2021-07-11 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 15:47 [BUG] org-goto slows down org-set-property Maxim Nikulin
2021-07-11 9:25 ` Maxim Nikulin [this message]
2021-07-11 11:49 ` Ihor Radchenko
2021-07-11 12:55 ` Maxim Nikulin
2021-07-11 14:20 ` Ihor Radchenko
2021-07-11 15:07 ` Maxim Nikulin
2021-07-11 16:00 ` Ihor Radchenko
2021-07-12 14:59 ` Maxim Nikulin
2021-07-13 14:21 ` John Kitchin
2024-07-07 12:38 ` Ihor Radchenko
2024-10-13 11:45 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='scedec$2g0$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).