From: Marco Wahl <marcowahlsoft@gmail.com>
To: Arthur Miller <arthur.miller@live.com>, Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28)
Date: Tue, 10 Aug 2021 22:52:35 +0200 [thread overview]
Message-ID: <87lf593tv0.fsf@gmail.com> (raw)
In-Reply-To: AM9PR09MB497784EE7902FAC6D4F5E7BA96F69@AM9PR09MB4977.eurprd09.prod.outlook.com
Arthur Miller <arthur.miller@live.com> writes:
> Kyle Meyer <kyle@kyleam.com> writes:
>
>> In 61e083732 (org-attach: Possibly delete empty attach directory,
>> 2021-07-09), you added a call to directory-empty-p. This function was
>> introduced in Emacs's 0806075520 (Add directory-empty-p and new argument
>> COUNT for directory-files-*, 2020-11-02) and hasn't yet made it into a
>> release.
>>
>> Could you update org-attach-sync to avoid using directory-empty-p (e.g.,
>> by inlining it or by adding a compatibility alias)?
> Can this help:
>
> #+begin_src emacs-lisp
>
> (when (version< emacs-version "28")
> (defun directory-empty-p (file-name)
> "Check if a directory contains any other files then dot-files"
> (when (file-directory-p file-name)
> (null (directory-files file-name nil
> directory-files-no-dot-files-regexp t)))))
>
> #+end_src
Thanks Kyle and Arthur!
Starting from Arthur's suggestion and Kyle's hint to the compatibility
alias I put org-directory-empty-p into org-compat.el. So there is
org-directory-empty-p now which provides the functionality of
directory-empty-p from Emacs 28 for smaller version Emacsen.
org-directory-empty-p is defined in org-compat.el. From there
org-directory-empty-p can (and hopefully will) be easily dropped when
the minimum required Emacs version for Org switches to 28.
Thanks again and best regards,
--
Marco
next prev parent reply other threads:[~2021-08-10 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 22:33 org-attach-sync uses directory-empty-p (new in Emacs 28) Kyle Meyer
2021-08-09 7:10 ` Arthur Miller
2021-08-10 20:52 ` Marco Wahl [this message]
2021-08-11 16:16 ` Maxim Nikulin
2021-08-11 21:17 ` Marco Wahl
2021-08-12 11:57 ` Maxim Nikulin
2021-08-15 9:11 ` Marco Wahl
2021-08-15 16:27 ` Maxim Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf593tv0.fsf@gmail.com \
--to=marcowahlsoft@gmail.com \
--cc=arthur.miller@live.com \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).