emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Marco Wahl <marcowahlsoft@gmail.com>
To: Maxim Nikulin <manikulin@gmail.com>, Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28)
Date: Sun, 15 Aug 2021 11:11:55 +0200	[thread overview]
Message-ID: <87wnonjcmc.fsf@gmail.com> (raw)
In-Reply-To: <sf32bh$8l1$1@ciao.gmane.io> (Maxim Nikulin's message of "Thu, 12 Aug 2021 18:57:35 +0700")

Maxim Nikulin <manikulin@gmail.com> writes:

>>> Compiling single /home/ubuntu/org-mode/lisp/org-compat.el...
>>>
>>> In end of data:
>>> org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not
>>> known to
>>>      be defined.

> I have never fought with this kind of problem. After looking at the
> other constructs in the org-compat.el file, I have tried
>
> (if (fboundp 'directory-empty-p)
>     (defalias 'org-directory-empty-p #'directory-empty-p)
>   (defun org-directory-empty-p (dir)
>     ; ...
>
> I have no idea if there are any drawbacks of such approach, I can only
> say that such form suppresses the warning.

Thanks Maxim and Kyle!

The latter suggestion landed in master a few minutes ago.


Have a great day!
--
Marco

next prev parent reply	other threads:[~2021-08-15  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08 22:33 org-attach-sync uses directory-empty-p (new in Emacs 28) Kyle Meyer
2021-08-09  7:10 ` Arthur Miller
2021-08-10 20:52   ` Marco Wahl
2021-08-11 16:16     ` Maxim Nikulin
2021-08-11 21:17       ` Marco Wahl
2021-08-12 11:57         ` Maxim Nikulin
2021-08-15  9:11           ` Marco Wahl [this message]
2021-08-15 16:27             ` Maxim Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnonjcmc.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).