[PATCH] Removes obsolete functions, variable and fix typos.

[PATCH] Removes obsolete functions, variable and fix typos.

[Noorul Islam]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hello all,

Attached is the patch which has following changes.

* lisp/org-agenda.el:
  - Removed obsolete functions, org-highlight-until-next-command and
org-unhighlight-once.
  - Removed obsolete variable org-agenda-remove-date.

* lisp/org.el
  - Fixed some typos.

Thanks and Regards,
Noorul

[-- Attachment #2: obsolete-funcs-and-typos.diff --]
[-- Type: text/x-diff, Size: 2374 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 2619914..9ebe2d2 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2970,7 +2970,6 @@ When EMPTY is non-nil, also include days without any entries."
 (defvar org-starting-day nil) ; local variable in the agenda buffer
 (defvar org-agenda-span nil) ; local variable in the agenda buffer
 (defvar org-include-all-loc nil) ; local variable
-(defvar org-agenda-remove-date nil) ; dynamically scoped FIXME: not used???
 
 ;;;###autoload
 (defun org-agenda-list (&optional include-all start-day ndays)
@@ -5536,16 +5535,6 @@ so that the date SD will be in that range."
   "Detach overlay INDEX."
   (funcall (if (featurep 'xemacs) 'detach-extent 'delete-overlay) org-hl))
 
-;; FIXME this is currently not used.
-(defun org-highlight-until-next-command (beg end &optional buffer)
-  "Move the highlight overlay to BEG/END, remove it before the next command."
-  (org-highlight beg end buffer)
-  (add-hook 'pre-command-hook 'org-unhighlight-once))
-(defun org-unhighlight-once ()
-  "Remove the highlight from its position, and this function from the hook."
-  (remove-hook 'pre-command-hook 'org-unhighlight-once)
-  (org-unhighlight))
-
 (defun org-agenda-follow-mode ()
   "Toggle follow mode in an agenda buffer."
   (interactive)
diff --git a/lisp/org.el b/lisp/org.el
index bf6573b..73117c8 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -13111,7 +13111,7 @@ user."
             deltadef (nth 2 delta)))
 
     ;; Check if there is an iso week date in there
-    ;; If yes, sore the info and postpone interpreting it until the rest
+    ;; If yes, store the info and postpone interpreting it until the rest
     ;; of the parsing is done
     (when (string-match "\\<\\(?:\\([0-9]+\\)-\\)?[wW]\\([0-9]\\{1,2\\}\\)\\(?:-\\([0-6]\\)\\)?\\([ \t]\\|$\\)" ans)
       (setq iso-year (if (match-end 1) (org-small-year-to-year (string-to-number (match-string 1 ans))))
@@ -13119,7 +13119,7 @@ user."
 	    iso-week (string-to-number (match-string 2 ans)))
       (setq ans (replace-match "" t t ans)))
 
-    ;; Help matching ISO dates with single digit month ot day, like 2006-8-11.
+    ;; Help matching ISO dates with single digit month or day, like 2006-8-11.
     (when (string-match
 	   "^ *\\(\\([0-9]+\\)-\\)?\\([0-1]?[0-9]\\)-\\([0-3]?[0-9]\\)\\([^-0-9]\\|$\\)" ans)
       (setq year (if (match-end 2)

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Removes obsolete functions, variable and fix typos.

[Noorul Islam]

Hi all,

Is something wrong with the patch. Curious to know why is it not applied.

Thanks and Regards
Noorul

On Sun, Nov 15, 2009 at 9:38 PM, Noorul Islam <gnukid@gmail.com> wrote:
> Hello all,
>
> Attached is the patch which has following changes.
>
> * lisp/org-agenda.el:
>  - Removed obsolete functions, org-highlight-until-next-command and
> org-unhighlight-once.
>  - Removed obsolete variable org-agenda-remove-date.
>
> * lisp/org.el
>  - Fixed some typos.
>
> Thanks and Regards,
> Noorul
>

Re: Re: [PATCH] Removes obsolete functions, variable and fix typos.

[Carsten Dominik]

On Nov 18, 2009, at 8:08 AM, Noorul Islam wrote:

> Hi all,
>
> Is something wrong with the patch. Curious to know why is it not  
> applied.

1. Because there are those days and sometimes weeks when I discover
    that I have about three lives besides managing Org-mode, and
    that these things sometimes need to get priority
2. Because I was very busy getting the current code into Emacs
    before feature freeze for 22.3, which made me delay looking
    at minor patches such as yours.
3. Because I only want to accept part of the patch, I'd like to
    keep the two unused functions, because I have used them
    in the past and may use them again.
4. Because I don't think I have a copyright assignment from you,
    so I always need to check if your patch is small enough
    (this one is, but please consider signing the paper so that
    I can skip this delay step next time)

:-)

Your patch is in the queue, and I will get to it.  When I
am rejecting a patch, I usually do that not silently but
explicitly.

Thanks for your contribution and sorry for stressing your patience.

- Carsten

>
> Thanks and Regards
> Noorul
>
> On Sun, Nov 15, 2009 at 9:38 PM, Noorul Islam <gnukid@gmail.com>  
> wrote:
>> Hello all,
>>
>> Attached is the patch which has following changes.
>>
>> * lisp/org-agenda.el:
>>  - Removed obsolete functions, org-highlight-until-next-command and
>> org-unhighlight-once.
>>  - Removed obsolete variable org-agenda-remove-date.
>>
>> * lisp/org.el
>>  - Fixed some typos.
>>
>> Thanks and Regards,
>> Noorul
>>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

Re: Re: [PATCH] Removes obsolete functions, variable and fix typos.

[Noorul Islam K M]

Carsten Dominik <carsten.dominik@gmail.com> writes:


> 4. Because I don't think I have a copyright assignment from you,
>    so I always need to check if your patch is small enough
>    (this one is, but please consider signing the paper so that
>    I can skip this delay step next time)

E-mailed assign@gnu.org

>
> :-)
>
> Your patch is in the queue, and I will get to it.  When I
> am rejecting a patch, I usually do that not silently but
> explicitly.

Okay, thank you! I will keep in mind that unless there is no rejection
mail then it is in your queue and I should not be bothered about it.

Thanks and Regards
Noorul

Re: [PATCH] Removes obsolete functions, variable and fix typos.

[Carsten Dominik]

Applied, except for removing those currently unused functions - I
want to have them available for future use.

Thanks!

- Carsten

On Nov 15, 2009, at 5:08 PM, Noorul Islam wrote:

> Hello all,
>
> Attached is the patch which has following changes.
>
> * lisp/org-agenda.el:
>  - Removed obsolete functions, org-highlight-until-next-command and
> org-unhighlight-once.
>  - Removed obsolete variable org-agenda-remove-date.
>
> * lisp/org.el
>  - Fixed some typos.
>
> Thanks and Regards,
> Noorul
> <obsolete-funcs-and- 
> typos.diff>_______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten