From: David Maus <dmaus@ictsoc.de>
To: nicholas.dokos@hp.com
Cc: David Maus <dmaus@ictsoc.de>, emacs-orgmode@gnu.org
Subject: Re: [BUG?] subtle sequencing error when setting org-bbdb-old in org-bbdb.el
Date: Fri, 02 Mar 2012 17:32:52 +0100 [thread overview]
Message-ID: <87k433t13f.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <6717.1330381319@alphaville>
At Mon, 27 Feb 2012 17:21:59 -0500,
Nick Dokos wrote:
>
> David Maus <dmaus@ictsoc.de> wrote:
>
> > > The problem was that org-bbdb is part of org-modules by default and that
> > > was loading org-bbdb way too early, certainly before bbdb itself was
> > > loaded. That would set the value to nil and nothing I would do could
> > > change it (short of whacking it with a setq).
> >
> > I pushed a patch that should fix this problem. I wrapped a
> > `eval-after-load' around the `defvar', this should make sure that the
> > variable is set after bbdb was loaded.
> >
>
> I still have a problem with one configuration (but not with another),
> but I haven't drilled down to figure out what the problem is. I was
> wondering however if the eval-after-load should be predicated on
> bbdb-com rather than bbdb[fn:1]: with this change, both of my tested
> configurations work (hardly a definitive test but perhaps better than
> nothing).
Thanks for the feedback. Eval after load 'bbdb-com would have been
better -- I just replaced the entire defvar by a check in
`org-bbdb-open' and `org-bbdb-store-link' for the required functions.
So this should really work now.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
next prev parent reply other threads:[~2012-03-02 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 9:20 [BUG?] subtle sequencing error when setting org-bbdb-old in org-bbdb.el Nick Dokos
2012-02-27 20:26 ` David Maus
2012-02-27 20:44 ` Nick Dokos
2012-02-27 22:21 ` Nick Dokos
2012-03-02 16:32 ` David Maus [this message]
2012-03-02 17:49 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k433t13f.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).