emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: David Maus <dmaus@ictsoc.de>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: [BUG?] subtle sequencing error when setting org-bbdb-old in org-bbdb.el
Date: Fri, 02 Mar 2012 12:49:19 -0500	[thread overview]
Message-ID: <14966.1330710559@alphaville> (raw)
In-Reply-To: Message from David Maus <dmaus@ictsoc.de> of "Fri, 02 Mar 2012 17:32:52 +0100." <87k433t13f.wl%dmaus@ictsoc.de>

David Maus <dmaus@ictsoc.de> wrote:

> At Mon, 27 Feb 2012 17:21:59 -0500,
> Nick Dokos wrote:
> > 
> > David Maus <dmaus@ictsoc.de> wrote:
> > 
> > > > The problem was that org-bbdb is part of org-modules by default and that
> > > > was loading org-bbdb way too early, certainly before bbdb itself was
> > > > loaded.  That would set the value to nil and nothing I would do could
> > > > change it (short of whacking it with a setq).
> > > 
> > > I pushed a patch that should fix this problem. I wrapped a
> > > `eval-after-load' around the `defvar', this should make sure that the
> > > variable is set after bbdb was loaded.
> > > 
> > 
> > I still have a problem with one configuration (but not with another),
> > but I haven't drilled down to figure out what the problem is. I was
> > wondering however if the eval-after-load should be predicated on
> > bbdb-com rather than bbdb[fn:1]: with this change, both of my tested
> > configurations work (hardly a definitive test but perhaps better than
> > nothing).
> Thanks for the feedback. Eval after load 'bbdb-com would have been
> better -- I just replaced the entire defvar by a check in
> `org-bbdb-open' and `org-bbdb-store-link' for the required functions.
> So this should really work now.

It does, at least in the two configurations I've tested: my full-blown one
and a minimal org one with bbdb loaded after the fact.

I'll be trying it with bbdb 3.x some time soon, I hope.

Thanks very much!

      reply	other threads:[~2012-03-02 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25  9:20 [BUG?] subtle sequencing error when setting org-bbdb-old in org-bbdb.el Nick Dokos
2012-02-27 20:26 ` David Maus
2012-02-27 20:44   ` Nick Dokos
2012-02-27 22:21   ` Nick Dokos
2012-03-02 16:32     ` David Maus
2012-03-02 17:49       ` Nick Dokos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14966.1330710559@alphaville \
    --to=nicholas.dokos@hp.com \
    --cc=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).