From: Kyle Meyer <kyle@kyleam.com>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] lisp/ob-core.el: pass expanded body to org-confirm-babel-evaluate
Date: Sun, 02 Aug 2020 23:05:11 -0400 [thread overview]
Message-ID: <87k0yg4efs.fsf@kyleam.com> (raw)
In-Reply-To: <CA+G3_PNbFeju_iN-L+hsY67-_TTVLcj7bPFCS+A-obfQ5wJu0A@mail.gmail.com>
Tom Gillespie writes:
> Sorry for the slow turnaround time on this one. Having now tested
> it, I think that your solution is a much better one for the time
> being, so please go ahead and apply it. From this discussion there are
> a number of good options for improvements in the future, but my
> priority would be to get the expanded version of the body passed to
> org-confirm-babel-evaluate asap with as few disturbances to the rest
> of the code base as possible. Best!
All right, sounds good. Applied in df5a83637.
Thanks.
next prev parent reply other threads:[~2020-08-03 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 19:53 [PATCH] lisp/ob-core.el: pass expanded body to org-confirm-babel-evaluate Tom Gillespie
2020-07-19 21:13 ` Kyle Meyer
2020-07-20 20:27 ` Tom Gillespie
2020-07-22 4:19 ` Kyle Meyer
2020-08-02 6:03 ` Tom Gillespie
2020-08-03 3:05 ` Kyle Meyer [this message]
2020-09-05 3:54 ` Tom Gillespie
2020-09-06 3:45 ` Kyle Meyer
2020-09-06 9:39 ` Tom Gillespie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0yg4efs.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).