From: Tom Gillespie <email@example.com>
To: Kyle Meyer <firstname.lastname@example.org>
Cc: emacs-orgmode <email@example.com>
Subject: Re: [PATCH] lisp/ob-core.el: pass expanded body to org-confirm-babel-evaluate
Date: Fri, 4 Sep 2020 20:54:42 -0700 [thread overview]
Message-ID: <CA+G3_PPYS2KAaXiBDeujTTpswCTzTuJRQsXwaji1MuRoc8N7vw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
Following up in this thread having investigated the impact of coderefs.
My conclusion is that coderefs need to be stripped out before they are
passed to org-confirm-babel-evaluate. They are not present in the
executed code and removing them is not something that a definition
of org-confirm-babel-evaluate should have to know anything about.
Right now I work around them by suggesting that users comment
out their coderefs. This works because my use case is restricted to
elisp code and I strip the comments using read, but other languages
would not have such an easy solution.
I have included a patch against maint that reuses the let block
from org-babel-execute-src-block to accomplish this.
[-- Attachment #2: 0001-lisp-ob-core.el-org-babel-check-confirm-evaluate-str.patch --]
[-- Type: application/x-patch, Size: 1320 bytes --]
next prev parent reply other threads:[~2020-09-05 3:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 19:53 [PATCH] lisp/ob-core.el: pass expanded body to org-confirm-babel-evaluate Tom Gillespie
2020-07-19 21:13 ` Kyle Meyer
2020-07-20 20:27 ` Tom Gillespie
2020-07-22 4:19 ` Kyle Meyer
2020-08-02 6:03 ` Tom Gillespie
2020-08-03 3:05 ` Kyle Meyer
2020-09-05 3:54 ` Tom Gillespie [this message]
2020-09-06 3:45 ` Kyle Meyer
2020-09-06 9:39 ` Tom Gillespie
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).