Re: [PATCH 2/7] New macro: Evaluate FORM in ENVIRONMENT

[David Maus <dmaus@ictsoc.de>]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

At Tue, 02 Aug 2011 12:50:05 +0200,
Štěpán Němec wrote:
> 
> On Tue, 02 Aug 2011 11:23:35 +0200
> David Maus wrote:
> 
> > * org-macs.el (org-eval-in-environment): New macro. Evaluate
> > FORM in ENVIRONMENT.
> > (org-with-uninterned): Move to top of file.
> > ---
> >  lisp/org-macs.el |   23 ++++++++++++++++++-----
> >  1 files changed, 18 insertions(+), 5 deletions(-)
> >
> > diff --git a/lisp/org-macs.el b/lisp/org-macs.el
> > index 53c60e5..7a0cc60 100644
> > --- a/lisp/org-macs.el
> > +++ b/lisp/org-macs.el
> > @@ -47,6 +47,12 @@
> >  (declare-function org-add-props "org-compat" (string plist &rest props))
> >  (declare-function org-string-match-p "org-compat" (&rest args))
> >  
> > +(defmacro org-with-uninterned (symbols &rest body)
> > +  `(let ,(mapcar (lambda (s)
> > +		   `(,s (make-symbol (symbol-name ',s)))) symbols)
> > +     ,@body))
> > +(put 'org-with-uninterned 'lisp-indent-function 1)
> > +
> 
> So in the previous commit you added this macro, in the next commit you
> move it to the top of the file? Why didn't you put it into the right
> place to begin with?
> 
> [...]
> 
> > +(defun org-make-parameter-alist (flat)
> > +  "Return alist based on FLAT.
> > +FLAT is a list with alternating symbol names and values. The
> > +returned alist is a list of lists with the symbol name in car and
> > +the value in cdr."
> > +  (when flat
> > +    (cons (list (car flat) (cadr flat))
> > +	  (org-make-parameter-alist (cddr flat)))))
> 
> This new function is not mentioned anywhere in the commit message.

Yepp. I messed up the branch, correction is on its way.

Best,
  -- David
-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]