From: "Štěpán Němec" <stepnem@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/7] New macro: Evaluate FORM in ENVIRONMENT
Date: Tue, 02 Aug 2011 12:50:05 +0200 [thread overview]
Message-ID: <87fwlk3x5u.fsf@gmail.com> (raw)
In-Reply-To: <1312277020-7888-3-git-send-email-dmaus@ictsoc.de> (David Maus's message of "Tue, 2 Aug 2011 11:23:35 +0200")
On Tue, 02 Aug 2011 11:23:35 +0200
David Maus wrote:
> * org-macs.el (org-eval-in-environment): New macro. Evaluate
> FORM in ENVIRONMENT.
> (org-with-uninterned): Move to top of file.
> ---
> lisp/org-macs.el | 23 ++++++++++++++++++-----
> 1 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-macs.el b/lisp/org-macs.el
> index 53c60e5..7a0cc60 100644
> --- a/lisp/org-macs.el
> +++ b/lisp/org-macs.el
> @@ -47,6 +47,12 @@
> (declare-function org-add-props "org-compat" (string plist &rest props))
> (declare-function org-string-match-p "org-compat" (&rest args))
>
> +(defmacro org-with-uninterned (symbols &rest body)
> + `(let ,(mapcar (lambda (s)
> + `(,s (make-symbol (symbol-name ',s)))) symbols)
> + ,@body))
> +(put 'org-with-uninterned 'lisp-indent-function 1)
> +
So in the previous commit you added this macro, in the next commit you
move it to the top of the file? Why didn't you put it into the right
place to begin with?
[...]
> +(defun org-make-parameter-alist (flat)
> + "Return alist based on FLAT.
> +FLAT is a list with alternating symbol names and values. The
> +returned alist is a list of lists with the symbol name in car and
> +the value in cdr."
> + (when flat
> + (cons (list (car flat) (cadr flat))
> + (org-make-parameter-alist (cddr flat)))))
This new function is not mentioned anywhere in the commit message.
--
Štěpán
next prev parent reply other threads:[~2011-08-02 10:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 9:23 [PATCH 0/8] Org mode macros, refactored David Maus
2011-08-02 9:23 ` [PATCH 1/7] New macro: Execute BODY in enviroment with uninterned SYMBOLS David Maus
2011-08-02 13:48 ` David Maus
[not found] ` <CAJcAo8uv46JCx9cG0x_ip9DMQ-aN=buLRO_fONPoFuDkik6J1Q@mail.gmail.com>
2011-08-10 7:43 ` David Maus
2011-08-16 16:34 ` Bastien
2011-08-16 17:08 ` David Maus
2011-08-16 17:30 ` Bastien
2011-08-02 9:23 ` [PATCH 2/7] New macro: Evaluate FORM in ENVIRONMENT David Maus
2011-08-02 10:50 ` Štěpán Němec [this message]
2011-08-02 13:25 ` David Maus
2011-08-02 13:49 ` David Maus
2011-08-02 9:23 ` [PATCH 3/7] Use new macro org-with-uninterned David Maus
2011-08-02 9:23 ` [PATCH 4/7] New function: Substitute posix classes in regular expression David Maus
2011-08-02 9:23 ` [PATCH 5/7] Use macro org-with-uninterned David Maus
2011-08-02 9:23 ` [PATCH 6/7] Use org-eval-in-environment, make macros functions David Maus
2011-08-02 9:23 ` [PATCH 7/7] Make org-batch-store-agenda-views a fun, use org-eval-in-environment David Maus
2011-08-02 9:34 ` [PATCH 0/8] Org mode macros, refactored David Maus
2011-08-02 10:44 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwlk3x5u.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).