emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Øyvind Stegard" <oyvinst@ifi.uio.no>
To: Daimrod <daimrod@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-contacts: Update contacts cache if it contains markers with no buffer
Date: Sat, 20 Jul 2013 17:33:50 +0200	[thread overview]
Message-ID: <87ip05uty9.fsf.rednorrock@ifi.uio.no> (raw)
In-Reply-To: <878v11cl2o.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 20 Jul 2013 17:22:55 +0200")

Daimrod <daimrod@gmail.com> writes:

[...]

> You're right, good catch!
>
> I've installed the patch and haven't felt any slowdown, but I've a small
> contacts file. If people complain about slowdown we could add a buffer
> local hook to ask before killing contacts files.

If speed turns out to be an issue, then simply caching references to the
contact buffers and validating those references with `buffer-live-p'
should be quicker and just as reliable.

(Checking markers was just a quick solution on my part that did not
require changes to any data structures.)


Øyvind
-- 
< Øyvind Stegard
 < http://stegard.net/

      reply	other threads:[~2013-07-20 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 11:07 [PATCH] org-contacts: Update contacts cache if it contains markers with no buffer Øyvind Stegard
2013-07-16 17:23 ` Daimrod
2013-07-17  7:36   ` Øyvind Stegard
2013-07-20 15:22     ` Daimrod
2013-07-20 15:33       ` Øyvind Stegard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip05uty9.fsf.rednorrock@ifi.uio.no \
    --to=oyvinst@ifi.uio.no \
    --cc=daimrod@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).