From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?=C3=98yvind?= Stegard Subject: Re: [PATCH] org-contacts: Update contacts cache if it contains markers with no buffer Date: Sat, 20 Jul 2013 17:33:50 +0200 Message-ID: <87ip05uty9.fsf.rednorrock@ifi.uio.no> References: <878v1cdoke.fsf.rednorrock@ifi.uio.no> <87fvvexvtl.fsf@tanger.home> <87zjtlwsbw.fsf.rednorrock@ifi.uio.no> <878v11cl2o.fsf@tanger.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0ZAV-0007Ni-CT for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0ZAR-0008Ds-66 for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:33:59 -0400 Received: from mail-out5.uio.no ([129.240.10.17]:58724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0ZAQ-0008DG-Vp for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:33:55 -0400 In-Reply-To: <878v11cl2o.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 20 Jul 2013 17:22:55 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Daimrod Cc: emacs-orgmode@gnu.org Daimrod writes: [...] > You're right, good catch! > > I've installed the patch and haven't felt any slowdown, but I've a small > contacts file. If people complain about slowdown we could add a buffer > local hook to ask before killing contacts files. If speed turns out to be an issue, then simply caching references to the contact buffers and validating those references with `buffer-live-p' should be quicker and just as reliable. (Checking markers was just a quick solution on my part that did not require changes to any data structures.) =C3=98yvind --=20 < =C3=98yvind Stegard < http://stegard.net/