emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Ivan Kanis <banana@kanis.fr>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] fix appointment warn time
Date: Sat, 27 Apr 2013 14:02:30 +0200	[thread overview]
Message-ID: <87haismbah.fsf@bzg.ath.cx> (raw)
In-Reply-To: <m0txmsmkws.fsf@kanis.fr> (Ivan Kanis's message of "Sat, 27 Apr 2013 10:34:43 +0200")

Ivan Kanis <banana@kanis.fr> writes:

> April, 26 at 19:01 Bastien wrote:
>
>>> The patch adds a function that goes at the beginning of the header to
>>> get the property. As a bonus it turns the string into a number.
>>>
>>> Please let me know if the patch is accepted or needs improvement.
>>
>> Can you try the attached patch instead?
>
> It works great and it looks less expensive. Thank you!

Great -- thanks for testing this.

Still, I need to really understand what real problem it fixes...
is it because some of your functions needs to check the property
or is it during regular use of Org?  Sorry if I missed this in
one of your previous message... and thanks in advance!

-- 
 Bastien

  reply	other threads:[~2013-04-27 12:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 16:17 [PATCH] fix appointment warn time Ivan Kanis
2013-04-26 17:01 ` Bastien
2013-04-27  8:34   ` Ivan Kanis
2013-04-27 12:02     ` Bastien [this message]
2013-04-28  8:48       ` Ivan Kanis
2013-04-28  8:59         ` Bastien
2013-04-28 19:57           ` Ivan Kanis
2013-05-14  8:36             ` Bastien
2013-05-14 11:46               ` Ivan Kanis
2013-05-14 11:49                 ` Bastien
2013-05-14 12:10                   ` Ivan Kanis
2013-05-14 13:20                     ` Miguel Ruiz
2013-05-14 14:08                       ` Bastien
2013-05-14 15:06                         ` Ivan Kanis
2013-05-14 15:18                           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haismbah.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=banana@kanis.fr \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).