From: Ihor Radchenko <yantar92@posteo.net>
To: "Marc Nieper-Wißkirchen" <marc@nieper-wisskirchen.de>
Cc: "Rudolf Adamkovič" <salutis@me.com>, emacs-orgmode@gnu.org
Subject: Re: Babel (scheme): Evaluation errors are not shown
Date: Sat, 31 Dec 2022 13:24:36 +0000 [thread overview]
Message-ID: <87h6xbaep7.fsf@localhost> (raw)
In-Reply-To: <CAEYrNrTtO-VjJKP2sjoGkM-D-5tN65eL0ur32TLoGCiGwxfWkQ@mail.gmail.com>
Marc Nieper-Wißkirchen <marc@nieper-wisskirchen.de> writes:
> Please find the patch file attached to this email.
Thanks!
I will give some general comments and leave the ob-scheme changes for
Rudolf.
> Subject: [PATCH] Display evaluation errors for Scheme code blocks.
If you can, please provide changelog entries explaining each change. See
https://orgmode.org/worg/org-contribute.html#commit-messages
> (let ((buf (get-buffer-create org-babel-error-buffer-name)))
> (with-current-buffer buf
> (goto-char (point-max))
> (save-excursion
> (unless (bolp) (insert "\n"))
> (insert stderr)
> - (insert (format "[ Babel evaluation exited with code %S ]" exit-code))))
> + (when exit-code
> + (insert (format "[ Babel evaluation exited with code %S ]" exit-code)))))
I think it will be more consistent to do something like
(if exit-code ... (insert " [ Babel evaluation exited abnormally ] "))
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-31 13:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 12:03 Babel (scheme): Evaluation errors are not shown Marc Nieper-Wißkirchen
2022-12-18 12:41 ` Ihor Radchenko
2022-12-20 0:39 ` Rudolf Adamkovič
2022-12-20 20:00 ` Marc Nieper-Wißkirchen
2022-12-31 9:50 ` Ihor Radchenko
2022-12-31 10:09 ` Marc Nieper-Wißkirchen
2022-12-31 10:19 ` Marc Nieper-Wißkirchen
2022-12-31 10:50 ` Marc Nieper-Wißkirchen
2022-12-31 12:07 ` Ihor Radchenko
2022-12-31 13:11 ` Marc Nieper-Wißkirchen
2022-12-31 13:24 ` Ihor Radchenko [this message]
2022-12-31 14:46 ` Marc Nieper-Wißkirchen
2023-01-01 13:53 ` Ihor Radchenko
2023-01-01 15:21 ` Marc Nieper-Wißkirchen
2023-01-02 9:38 ` Ihor Radchenko
2023-01-02 9:52 ` Marc Nieper-Wißkirchen
2023-01-03 9:07 ` Ihor Radchenko
2023-01-07 14:26 ` Marc Nieper-Wißkirchen
2023-01-25 13:12 ` Ihor Radchenko
2023-01-05 8:55 ` Marc Nieper-Wißkirchen
2023-01-06 16:17 ` Ihor Radchenko
2023-01-06 16:20 ` Ihor Radchenko
2023-01-06 16:32 ` tomas
2023-01-06 20:47 ` Marc Nieper-Wißkirchen
2023-01-07 13:28 ` Bastien Guerry
2022-12-21 13:25 ` Ihor Radchenko
2022-12-29 15:34 ` Bastien Guerry
2023-01-03 23:28 ` Rudolf Adamkovič
2023-01-03 23:35 ` Bastien
2023-01-06 20:45 ` Rudolf Adamkovič
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6xbaep7.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=marc@nieper-wisskirchen.de \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).