From: "Marc Nieper-Wißkirchen" <marc@nieper-wisskirchen.de>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: "Rudolf Adamkovič" <salutis@me.com>, emacs-orgmode@gnu.org
Subject: Re: Babel (scheme): Evaluation errors are not shown
Date: Thu, 5 Jan 2023 09:55:32 +0100 [thread overview]
Message-ID: <CAEYrNrSrCjq4jaQ_jEvOA6ABCF9Ah9Oody+8+QpVnenodRqsAg@mail.gmail.com> (raw)
In-Reply-To: <CAEYrNrT7S-2RZ4Ev=Rxy=wLcOS3o92sjH7ED_Ys4k8za_9WHKQ@mail.gmail.com>
Despite the unfortunate lack of a maintainer, I hope the (latest
version of the) patch can still be applied as the current behavior of
ob-scheme.el, namely, silencing any evaluation errors is infeasible.
Do you need any FSF copyright assignments from me? (I already
contributed to GCC and Gnulib under such an assignment in the past.)
Thanks,
Marc
Am Mo., 2. Jan. 2023 um 10:52 Uhr schrieb Marc Nieper-Wißkirchen
<marc@nieper-wisskirchen.de>:
>
> Am Mo., 2. Jan. 2023 um 10:38 Uhr schrieb Ihor Radchenko <yantar92@posteo.net>:
> >
> > Marc Nieper-Wißkirchen <marc@nieper-wisskirchen.de> writes:
> >
> > > Fixed.
> >
> > Thanks!
> > Note that your patch does not apply onto main.
>
> Rebased against the latest main. Please see the appended patch.
>
> >
> > > - (setq result (if output
> > > + (let ((err (geiser-eval--retort-error ret)))
> > > + (setq result (cond
> > > + (err nil)
> >
> > We may still provide output, if any. Even in the case of error. Not sure
> > if it makes sense for ob-scheme though.
>
> I switched the two cases, "err" and "output," in the attached patch.
> For a value result, providing a result in case of an error does not
> make sense.
>
> Thanks for your patience,
>
> Marc
next prev parent reply other threads:[~2023-01-05 8:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 12:03 Babel (scheme): Evaluation errors are not shown Marc Nieper-Wißkirchen
2022-12-18 12:41 ` Ihor Radchenko
2022-12-20 0:39 ` Rudolf Adamkovič
2022-12-20 20:00 ` Marc Nieper-Wißkirchen
2022-12-31 9:50 ` Ihor Radchenko
2022-12-31 10:09 ` Marc Nieper-Wißkirchen
2022-12-31 10:19 ` Marc Nieper-Wißkirchen
2022-12-31 10:50 ` Marc Nieper-Wißkirchen
2022-12-31 12:07 ` Ihor Radchenko
2022-12-31 13:11 ` Marc Nieper-Wißkirchen
2022-12-31 13:24 ` Ihor Radchenko
2022-12-31 14:46 ` Marc Nieper-Wißkirchen
2023-01-01 13:53 ` Ihor Radchenko
2023-01-01 15:21 ` Marc Nieper-Wißkirchen
2023-01-02 9:38 ` Ihor Radchenko
2023-01-02 9:52 ` Marc Nieper-Wißkirchen
2023-01-03 9:07 ` Ihor Radchenko
2023-01-07 14:26 ` Marc Nieper-Wißkirchen
2023-01-25 13:12 ` Ihor Radchenko
2023-01-05 8:55 ` Marc Nieper-Wißkirchen [this message]
2023-01-06 16:17 ` Ihor Radchenko
2023-01-06 16:20 ` Ihor Radchenko
2023-01-06 16:32 ` tomas
2023-01-06 20:47 ` Marc Nieper-Wißkirchen
2023-01-07 13:28 ` Bastien Guerry
2022-12-21 13:25 ` Ihor Radchenko
2022-12-29 15:34 ` Bastien Guerry
2023-01-03 23:28 ` Rudolf Adamkovič
2023-01-03 23:35 ` Bastien
2023-01-06 20:45 ` Rudolf Adamkovič
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYrNrSrCjq4jaQ_jEvOA6ABCF9Ah9Oody+8+QpVnenodRqsAg@mail.gmail.com \
--to=marc@nieper-wisskirchen.de \
--cc=emacs-orgmode@gnu.org \
--cc=salutis@me.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).