From: Ihor Radchenko <yantar92@posteo.net>
To: Phil Estival <pe@7d.nz>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: patch : ob-sql :session
Date: Mon, 11 Nov 2024 15:57:53 +0000 [thread overview]
Message-ID: <87h68doj9a.fsf@localhost> (raw)
In-Reply-To: <6daf618b-ef67-497b-aa1c-aaa1f4804143@7d.nz>
Phil Estival <pe@7d.nz> writes:
> I will keep running ob-sql with :session in the next days.
> This work configuration should help to detect if there is an anomaly.
>
> Shall I submit a patch?
Sure!
> Since many lines are changed due to proper indentation, docstrings,
> untabification and a few lateral improvements, I was wondering if
> such a patch has to be gradual and minimize sudden changes.
If you can make a series of patches introducing individual changes, it
would be best. A single patch will also be ok.
> Also I'm trying to run the tests with
>
> : make BTEST_RE='ob-sql.*' test-dirty
>
> but they get skipped due to a missing dependency,
> and I don't know in which direction to look for from there.
> Below is what the command returns. Any idea ?
Check your local.mk
ob-sql tests are disabled by default. You need to modify BTEST_OB_LANGUAGES
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-11-11 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b1ca8e9e-be59-4740-8ea8-c3ebd4ba56fe@7d.nz>
[not found] ` <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>
2024-09-17 10:00 ` packages submissions : ob-sql-session and org-blog Phil Estival
2024-09-17 22:25 ` Adam Porter
2024-09-18 1:41 ` package submission : ob-sql-session Phil Estival
2024-10-20 12:34 ` Ihor Radchenko
2024-11-04 18:16 ` Phil Estival
2024-11-09 14:43 ` Ihor Radchenko
2024-11-11 10:51 ` patch : ob-sql :session Phil Estival
2024-11-11 15:57 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h68doj9a.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=pe@7d.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).