emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Phil Estival <pe@7d.nz>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org, Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: packages submissions : ob-sql-session and org-blog
Date: Tue, 17 Sep 2024 12:00:57 +0200	[thread overview]
Message-ID: <ac77266a-b979-4f8e-b126-23b8f2b51a03@7d.nz> (raw)
In-Reply-To: <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>


* [2024-09-11 05:01] Adam Porter:
> Hi Phil,
> 
> A quick, initial suggestion: it would be good to reformat the Lisp code 
> in both projects, as I see several cases of incorrect indentation, 
> hanging parens, extra blank lines, etc, and some of them would make the 
> code hard to read.  For my Lisp editing, I use aggressive-indent-mode, 
> which ensures that the code is always indented correctly.  For some 
> other reformatting, Oleh Krehel's Lispy package has commands to help.

Hi Adam,

> Also, for org-sql-session (which sounds very useful), it would be good
> to compare and contrast it with the package it's meant to supersede.

The following comparison was added to the readme file.

ob-sql-mode :
- is very simple : forward the sql source through `sql-redirect'
- has a test suite
- but gives clunky output
- no :results table
- sql client shell commands messes up output
- prompt again for connection parameters when restarting a session

ob-sql-session :
- handle large results
- has :results tables
- accept header variables (:var)
- accept sql client shell commands
- keep login parameters
- prompt only for blank connection parameters
- can use `with-environment-variables'
- provide some more tests

> since it's meant to integrate with org-babel, it might be good to 
> discuss its inclusion on the Org mailing list also.

CC-ing the Org mailing list.

Phil


       reply	other threads:[~2024-09-17 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b1ca8e9e-be59-4740-8ea8-c3ebd4ba56fe@7d.nz>
     [not found] ` <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>
2024-09-17 10:00   ` Phil Estival [this message]
2024-09-17 22:25     ` packages submissions : ob-sql-session and org-blog Adam Porter
2024-09-18  1:41       ` package submission : ob-sql-session Phil Estival
2024-10-20 12:34         ` Ihor Radchenko
2024-11-04 18:16           ` Phil Estival
2024-11-09 14:43             ` Ihor Radchenko
2024-11-11 10:51               ` patch : ob-sql :session Phil Estival
2024-11-11 15:57                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac77266a-b979-4f8e-b126-23b8f2b51a03@7d.nz \
    --to=pe@7d.nz \
    --cc=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).