emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org,
	Sebastien Vauban
	<public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org>
Subject: Re: [PATCH] Improve message when file to include is missing
Date: Fri, 24 Jan 2014 12:19:49 +0100	[thread overview]
Message-ID: <87fvodtyne.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87fvodvdh9.fsf@gmail.com> (Nicolas Goaziou's message of "Fri, 24 Jan 2014 12:14:10 +0100")



Nicolas Goaziou <n.goaziou@gmail.com> writes:

> What if `buffer-file-name' returns nil? Sure, the problem won't happen
> during agenda generation, but `org-file-contents' is used elsewhere.
>
> Also, it is better to use:
>
>   (buffer-file-name (buffer-base-buffer))
>
> since the current buffer may be an indirect one.

I reverted the commit -- I let you guys discuss it and provide the
correct one.

Thanks,

-- 
 Bastien

  reply	other threads:[~2014-01-24 11:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 10:49 [PATCH] Improve message when file to include is missing Sebastien Vauban
2014-01-24 11:14 ` Nicolas Goaziou
2014-01-24 11:19   ` Bastien [this message]
2014-02-18 14:55   ` Sebastien Vauban
2014-02-18 20:21     ` Nicolas Goaziou
2014-02-18 20:32       ` Sebastien Vauban
2014-02-18 22:10         ` Nicolas Goaziou
2014-01-24 11:15 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvodtyne.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=n.goaziou@gmail.com \
    --cc=public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org \
    --cc=public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).