From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Improve message when file to include is missing Date: Fri, 24 Jan 2014 12:19:49 +0100 Message-ID: <87fvodtyne.fsf@bzg.ath.cx> References: <86wqhpu021.fsf@somewhere.org> <87fvodvdh9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6eo5-00064S-1W for emacs-orgmode@gnu.org; Fri, 24 Jan 2014 06:20:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6enw-0005ZG-GM for emacs-orgmode@gnu.org; Fri, 24 Jan 2014 06:20:16 -0500 Received: from plane.gmane.org ([80.91.229.3]:42537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6enw-0005ZA-9I for emacs-orgmode@gnu.org; Fri, 24 Jan 2014 06:20:08 -0500 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1W6enu-00078P-BM for emacs-orgmode@gnu.org; Fri, 24 Jan 2014 12:20:06 +0100 In-Reply-To: <87fvodvdh9.fsf@gmail.com> (Nicolas Goaziou's message of "Fri, 24 Jan 2014 12:14:10 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org, Sebastien Vauban Nicolas Goaziou writes: > What if `buffer-file-name' returns nil? Sure, the problem won't happen > during agenda generation, but `org-file-contents' is used elsewhere. > > Also, it is better to use: > > (buffer-file-name (buffer-base-buffer)) > > since the current buffer may be an indirect one. I reverted the commit -- I let you guys discuss it and provide the correct one. Thanks, -- Bastien