emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Sebastian Reuße" <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org: Support creating arbitrary headline paths when refiling
Date: Wed, 10 Oct 2018 12:49:32 +0200	[thread overview]
Message-ID: <87ftxecc03.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20181007135831.26003-1-seb@wirrsal.net> ("Sebastian Reuße"'s message of "Sun, 7 Oct 2018 15:58:31 +0200")

Hello,

Sebastian Reuße <seb@wirrsal.net> writes:

> * org.el (org--refile-new-path): Add.
> (org-refile): Use it.
> (org-refile-new-child): Make new nodes more compact.
>
> * test-org.el (test-org/org-refile): Add test.
>
> While ‘org-refile’ currently supports creating new headlines when
> refiling, only one single headline can be created this way. For
> convenience, we now generalize this use-case to support creating
> arbitrary headline paths on the fly.

Compiling your patch generates the following warnings.

    org.el:11417:1:Warning: Unused lexical variable ‘parent’
    org.el:11417:1:Warning: Unused lexical variable ‘child’
    org.el:11417:1:Warning: Unused lexical variable ‘parent-target’

Also, I couldn't test it because completing asks for a mandatory match
among candidates. Such a match is not possible if you need to create
a path out of the blue. Am I missing something?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-10-10 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07 13:58 [PATCH] org: Support creating arbitrary headline paths when refiling Sebastian Reuße
2018-10-10 10:49 ` Nicolas Goaziou [this message]
2018-10-10 11:24   ` Sebastian Reuße
2018-10-11  6:35     ` Sebastian Reuße
2018-10-11 11:30       ` Sebastian Reuße
2018-10-14  7:38         ` Nicolas Goaziou
2018-10-14  8:04           ` Sebastian Reuße
2018-10-14  8:58             ` Headlines with slashes " Sebastian Reuße
2018-10-14  8:05           ` [PATCH] org: Support creating arbitrary headline paths " Sebastian Reuße
2018-10-14 14:14             ` Nicolas Goaziou
2018-10-14 14:30               ` Sebastian Reuße
2018-10-14 20:24                 ` Nicolas Goaziou
2018-10-10 11:27   ` Sebastian Reuße

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftxecc03.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=seb@wirrsal.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).