emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sebastian Reuße" <seb@wirrsal.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org: Support creating arbitrary headline paths when refiling
Date: Wed, 10 Oct 2018 13:27:37 +0200	[thread overview]
Message-ID: <87lg76ca8m.fsf@wirrsal.net> (raw)
In-Reply-To: <87ftxecc03.fsf@nicolasgoaziou.fr>

Hello Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Compiling your patch generates the following warnings.
>
>     org.el:11417:1:Warning: Unused lexical variable ‘parent’
>     org.el:11417:1:Warning: Unused lexical variable ‘child’
>     org.el:11417:1:Warning: Unused lexical variable 
>     ‘parent-target’

Good catch, thanks. I forgot to remove these let-bindings when 
factoring the respective ‘org-refile’ branch into a separate 
function. I amended the commit correspondingly.

> Also, I couldn't test it because completing asks for a mandatory 
> match
> among candidates. Such a match is not possible if you need to 
> create
> a path out of the blue. Am I missing something?

Do you have ‘org-refile-allow-creating-parent-nodes’ set to an 
appropriate value? When non-nil, ‘org-refile’ should invoke the 
completing read function without requiring a full match.

Kind regards,

SR

-- 
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay

      parent reply	other threads:[~2018-10-10 11:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07 13:58 [PATCH] org: Support creating arbitrary headline paths when refiling Sebastian Reuße
2018-10-10 10:49 ` Nicolas Goaziou
2018-10-10 11:24   ` Sebastian Reuße
2018-10-11  6:35     ` Sebastian Reuße
2018-10-11 11:30       ` Sebastian Reuße
2018-10-14  7:38         ` Nicolas Goaziou
2018-10-14  8:04           ` Sebastian Reuße
2018-10-14  8:58             ` Headlines with slashes " Sebastian Reuße
2018-10-14  8:05           ` [PATCH] org: Support creating arbitrary headline paths " Sebastian Reuße
2018-10-14 14:14             ` Nicolas Goaziou
2018-10-14 14:30               ` Sebastian Reuße
2018-10-14 20:24                 ` Nicolas Goaziou
2018-10-10 11:27   ` Sebastian Reuße [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg76ca8m.fsf@wirrsal.net \
    --to=seb@wirrsal.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).