From: Ihor Radchenko <yantar92@posteo.net>
To: Visuwesh <visuweshm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
Date: Sat, 15 Jun 2024 13:37:44 +0000 [thread overview]
Message-ID: <87frtegwd3.fsf@localhost> (raw)
In-Reply-To: <87a5jm6bz1.fsf@gmail.com>
Visuwesh <visuweshm@gmail.com> writes:
>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
>
> Done in the attached patch.
Thanks!
> ;; Dump table to datafile
> - (let ((dump-func (plist-get type :data-dump)))
> + (let* ((dump-func (plist-get type :data-dump)))
Why let*?
> + (setq data-file (org-babel-temp-stable-file
> + (list (or dump-func 'org-plot/gnuplot-to-data)
> + table num-cols params)
> + "org-plot"))
Please add in-code comment explaining why we need `org-babel-temp-stable-file'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-06-15 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 9:28 [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] Visuwesh
2024-06-04 13:09 ` Ihor Radchenko
2024-06-13 7:08 ` Visuwesh
2024-06-14 13:53 ` Ihor Radchenko
2024-06-15 4:56 ` Visuwesh
2024-06-15 13:37 ` Ihor Radchenko [this message]
2024-06-17 4:56 ` Visuwesh
2024-06-17 17:10 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frtegwd3.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).