From: Visuwesh <visuweshm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
Date: Mon, 17 Jun 2024 10:26:22 +0530 [thread overview]
Message-ID: <87plsg416x.fsf@gmail.com> (raw)
In-Reply-To: <87frtegwd3.fsf@localhost> (Ihor Radchenko's message of "Sat, 15 Jun 2024 13:37:44 +0000")
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
[சனி ஜூன் 15, 2024] Ihor Radchenko wrote:
> Visuwesh <visuweshm@gmail.com> writes:
>
>>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
>>
>> Done in the attached patch.
>
> Thanks!
>
>> ;; Dump table to datafile
>> - (let ((dump-func (plist-get type :data-dump)))
>> + (let* ((dump-func (plist-get type :data-dump)))
>
> Why let*?
Oops, leftover change from a previous iteration of the patch. Now
fixed.
>> + (setq data-file (org-babel-temp-stable-file
>> + (list (or dump-func 'org-plot/gnuplot-to-data)
>> + table num-cols params)
>> + "org-plot"))
>
> Please add in-code comment explaining why we need `org-babel-temp-stable-file'.
Now done.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-plot-Make-data-file-stable-for-replot-on-resize.patch --]
[-- Type: text/x-diff, Size: 2399 bytes --]
From a922946b3965e117dc3bbbe5a4f3c67dcc832d68 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Sat, 15 Jun 2024 10:25:19 +0530
Subject: [PATCH] org-plot: Make data-file stable for replot-on-resize
* lisp/org-plot.el (org-plot/gnuplot): Use a stable data-file to make
replot-on-resize in GUI terminals work.
Reported-by: Visuwesh <visuweshm@gmail.com>
Link: https://orgmode.org/list/87mso7sl6g.fsf@gmail.com
---
lisp/org-plot.el | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lisp/org-plot.el b/lisp/org-plot.el
index 283d993..83483b2 100644
--- a/lisp/org-plot.el
+++ b/lisp/org-plot.el
@@ -662,8 +662,7 @@ (defun org-plot/gnuplot (&optional params)
(looking-at "[[:space:]]*#\\+"))
(setf params (org-plot/collect-options params))))
;; collect table and table information
- (let* ((data-file (make-temp-file "org-plot"))
- (table (let ((tbl (save-excursion
+ (let* ((table (let ((tbl (save-excursion
(org-plot/goto-nearest-table)
(org-table-to-lisp))))
(when (pcase (plist-get params :transpose)
@@ -681,12 +680,11 @@ (defun org-plot/gnuplot (&optional params)
(nth 0 table))))
(type (assoc (plist-get params :plot-type)
org-plot/preset-plot-types))
- gnuplot-script)
+ gnuplot-script data-file)
(unless type
(user-error "Org-plot type `%s' is undefined" (plist-get params :plot-type)))
- (run-with-idle-timer 0.1 nil #'delete-file data-file)
(when (eq (cadr table) 'hline)
(setf params
(plist-put params :labels (car table))) ; headers to labels
@@ -697,6 +695,12 @@ (defun org-plot/gnuplot (&optional params)
(setf params (org-plot/collect-options params))))
;; Dump table to datafile
(let ((dump-func (plist-get type :data-dump)))
+ ;; Use a stable temporary file to ensure that 'replot' upon
+ ;; resizing a GUI gnuplot terminal window works.
+ (setq data-file (org-babel-temp-stable-file
+ (list (or dump-func 'org-plot/gnuplot-to-data)
+ table num-cols params)
+ "org-plot"))
(if dump-func
(funcall dump-func table data-file num-cols params)
(org-plot/gnuplot-to-data table data-file params)))
--
2.43.0
next prev parent reply other threads:[~2024-06-17 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 9:28 [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] Visuwesh
2024-06-04 13:09 ` Ihor Radchenko
2024-06-13 7:08 ` Visuwesh
2024-06-14 13:53 ` Ihor Radchenko
2024-06-15 4:56 ` Visuwesh
2024-06-15 13:37 ` Ihor Radchenko
2024-06-17 4:56 ` Visuwesh [this message]
2024-06-17 17:10 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plsg416x.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).