emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: "David Dynerman" <emperordali@block-party.net>,
	25132@debbugs.gnu.org,
	"Clément Pit--Claudel" <clement.pit@gmail.com>
Subject: bug#25132: 26.0.50; emacs hangs when loading org file with python source blocks
Date: Sun, 29 Jan 2017 11:05:54 -0500	[thread overview]
Message-ID: <87efzlsvfh.fsf__31923.9692450084$1485705956$gmane$org@users.sourceforge.net> (raw)
In-Reply-To: <874m0puo2a.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 23 Jan 2017 22:36:13 -0500")

tags 25132 fixed
close 25132 25.2
quit

npostavs@users.sourceforge.net writes:

> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> So, personally, I'd try to fix the particular instance
>> first. Switching buffers inside with-silent-modifications is not a
>> very common usage, I think.
>>
>> Maybe org-src should itself let-bind the aforementioned variable(s)
>> where it visits other buffers.
>
> Yeah, that works, and is my proposal for emacs-25, but I'm still leaning
> towards solving this more broadly in with-silent-modifications, probably
> also add a mention about this to the inhibit-modification-hooks
> docstring.

I changed my mind.  Bug#25561 reminded me about the "Making <var> local
to <buffer> while let-bound!" message.  My change to
`with-silent-modifications' would trigger that on any nested invocations
of `with-silent-modifications' which seems more likely to happen than
switching buffers.

I've pushed the simpler let-bind in org-src solution [1: ae8264c] to
emacs-25.

1: 2017-01-29 11:01:32 -0500 ae8264c5cccf19d5b25a340a605bf2f07de1577e
  Call modification hooks in org-src fontify buffers

      parent reply	other threads:[~2017-01-29 16:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m2fulz4mjc.fsf@CIVIC-TV.local>
2016-12-08  2:08 ` bug#25132: 26.0.50; emacs hangs when loading org file with python source blocks Glenn Morris
     [not found] ` <qwa8c75g0r.fsf@fencepost.gnu.org>
2016-12-08  2:40   ` Clément Pit--Claudel
     [not found]   ` <4aa23451-b6cd-88b0-369e-99f6fe5f2175@gmail.com>
2016-12-08  7:17     ` David Dynerman
     [not found]     ` <m260murisv.fsf@block-party.net>
2017-01-07  6:38       ` npostavs
     [not found]       ` <87y3yn2x4j.fsf@users.sourceforge.net>
2017-01-07 21:20         ` npostavs
2017-01-19 16:25           ` Dmitry Gutov
2017-01-20  0:52             ` npostavs
     [not found]             ` <878tq6wo1p.fsf@users.sourceforge.net>
2017-01-20  2:22               ` Clément Pit--Claudel
     [not found]               ` <4674bf9b-38f0-8839-fadb-e9a719faf163@gmail.com>
2017-01-20  3:18                 ` npostavs
2017-01-23  3:53               ` Dmitry Gutov
     [not found]               ` <345079d3-9578-9ab9-1444-353843a70f8b@yandex.ru>
2017-01-24  3:36                 ` npostavs
     [not found]                 ` <874m0puo2a.fsf@users.sourceforge.net>
2017-01-29 16:05                   ` npostavs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87efzlsvfh.fsf__31923.9692450084$1485705956$gmane$org@users.sourceforge.net' \
    --to=npostavs@users.sourceforge.net \
    --cc=25132@debbugs.gnu.org \
    --cc=clement.pit@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emperordali@block-party.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).