From mboxrd@z Thu Jan 1 00:00:00 1970 From: npostavs@users.sourceforge.net Subject: bug#25132: 26.0.50; emacs hangs when loading org file with python source blocks Date: Sun, 29 Jan 2017 11:05:54 -0500 Message-ID: <87efzlsvfh.fsf__31923.9692450084$1485705956$gmane$org@users.sourceforge.net> References: <4aa23451-b6cd-88b0-369e-99f6fe5f2175@gmail.com> <87y3yn2x4j.fsf@users.sourceforge.net> <87eg0e36un.fsf@users.sourceforge.net> <878tq6wo1p.fsf@users.sourceforge.net> <345079d3-9578-9ab9-1444-353843a70f8b@yandex.ru> <874m0puo2a.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXryV-0000DM-Qu for emacs-orgmode@gnu.org; Sun, 29 Jan 2017 11:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXryU-0008VS-W1 for emacs-orgmode@gnu.org; Sun, 29 Jan 2017 11:05:07 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <874m0puo2a.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 23 Jan 2017 22:36:13 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Dmitry Gutov Cc: David Dynerman , 25132@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel tags 25132 fixed close 25132 25.2 quit npostavs@users.sourceforge.net writes: > Dmitry Gutov writes: > >> So, personally, I'd try to fix the particular instance >> first. Switching buffers inside with-silent-modifications is not a >> very common usage, I think. >> >> Maybe org-src should itself let-bind the aforementioned variable(s) >> where it visits other buffers. > > Yeah, that works, and is my proposal for emacs-25, but I'm still leaning > towards solving this more broadly in with-silent-modifications, probably > also add a mention about this to the inhibit-modification-hooks > docstring. I changed my mind. Bug#25561 reminded me about the "Making local to while let-bound!" message. My change to `with-silent-modifications' would trigger that on any nested invocations of `with-silent-modifications' which seems more likely to happen than switching buffers. I've pushed the simpler let-bind in org-src solution [1: ae8264c] to emacs-25. 1: 2017-01-29 11:01:32 -0500 ae8264c5cccf19d5b25a340a605bf2f07de1577e Call modification hooks in org-src fontify buffers