emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Neil Jerram <neiljerram@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Capture with date prompt defaults to yesterday
Date: Mon, 10 Jun 2019 11:22:31 +0200	[thread overview]
Message-ID: <87ef41lrqg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAKuG=vs3jN=tRWiH5vjAeJh3cnq+W9gTL7HJzGUEW=aheTeqyg@mail.gmail.com> (Neil Jerram's message of "Sun, 9 Jun 2019 11:40:53 +0100")

Hello,

Neil Jerram <neiljerram@gmail.com> writes:

> Yes, it does make the default time noon.  But AFAICS the time of day
> doesn't actually matter in any of the Org source code where the result of
> org-get-cursor-date is used.  Have I missed a case where it does
> matter?

Probably not. I didn't check. But this could become a future gotcha.

> However, in the attached patch I've revised that so that the default time
> of day is <org-extend-today-until>:00am, i.e. it's the earliest time that
> Org treats as being that date.  WDYT?

I think this is better. I applied your patch. Thank you.

> Alternatively, we could refactor the code around where org-get-cursor-date
> is used to make it more explicit when the time of day doesn't matter, and
> look further if there are any cases where it does.

I think the current state is sufficient.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-06-10  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 13:36 Capture with date prompt defaults to yesterday Neil Jerram
2019-05-28 20:20 ` Neil Jerram
2019-06-07 12:33   ` Neil Jerram
2019-06-07 21:31     ` Nicolas Goaziou
2019-06-09 10:40       ` Neil Jerram
2019-06-10  9:22         ` Nicolas Goaziou [this message]
2019-06-11  8:53           ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef41lrqg.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=neiljerram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).