From: Neil Jerram <neiljerram@gmail.com>
To: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Capture with date prompt defaults to yesterday
Date: Tue, 28 May 2019 21:20:45 +0100 [thread overview]
Message-ID: <CAKuG=vuAs6-iHPzHg9LtptFZjj-DssFLfR-V7wZvxOxqEWZMdQ@mail.gmail.com> (raw)
In-Reply-To: <CAKuG=vtX01eFXkymVPbP4MK7Ym+oUm0UMtwwYZ7tP-3GDaEcCA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 827 bytes --]
On Sun, 19 May 2019 at 14:36, Neil Jerram <neiljerram@gmail.com> wrote:
> I have a capture template like this:
>
> '(org-capture-templates
> (quote
> (("a" "" entry
> (file "~/org/capture.org")
> "** TODO %?
> SCHEDULED: %^t"))))
>
> When I use that, the date prompt defaults to yesterday, whereas I'd expect
> it to default to today.
>
> I believe this is because I also have (setq org-extend-today-until 2).
> What happens is that (org-get-cursor-date) gets the right _date_, then
> converts that to a time at midnight, i.e. <date> 00:00. And then, I
> presume, some following code thinks that means <date>-1, because of my
> org-extend-today-until setting.
>
> Thoughts?
>
> Many thanks,
> Neil
>
Well I think it's a bug and propose the attached fix. Please let me know
what you think.
Neil
[-- Attachment #1.2: Type: text/html, Size: 1504 bytes --]
[-- Attachment #2: 0001-Make-capture-s-idea-of-the-current-day-more-intuitiv.patch --]
[-- Type: text/x-patch, Size: 1665 bytes --]
From d52c66f4e4f1fead135427d2c638890b5c7ab224 Mon Sep 17 00:00:00 2001
From: Neil Jerram <neil@tigera.io>
Date: Tue, 28 May 2019 21:01:17 +0100
Subject: [PATCH] Make capture's idea of the current day more intuitive
---
lisp/org.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index c6861dc9a..763eb1e45 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18936,7 +18936,9 @@ Returns the number of empty lines passed."
This works in the calendar and in the agenda, anywhere else it just
returns the current time.
If WITH-TIME is non-nil, returns the time of the event at point (in
-the agenda) or the current time of the day."
+the agenda) or the current time of the day; otherwise returns 12pm
+on the cursor date. (Returning 12pm instead of 12am here avoids
+problems of interpretation with respect to `org-extend-today-until'.)"
(let (date day defd tp hod mod)
(when with-time
(setq tp (get-text-property (point) 'time))
@@ -18949,13 +18951,13 @@ the agenda) or the current time of the day."
(cond
((eq major-mode 'calendar-mode)
(setq date (calendar-cursor-to-date)
- defd (encode-time 0 (or mod 0) (or hod 0)
+ defd (encode-time 0 (or mod 0) (or hod 12)
(nth 1 date) (nth 0 date) (nth 2 date))))
((eq major-mode 'org-agenda-mode)
(setq day (get-text-property (point) 'day))
(when day
(setq date (calendar-gregorian-from-absolute day)
- defd (encode-time 0 (or mod 0) (or hod 0)
+ defd (encode-time 0 (or mod 0) (or hod 12)
(nth 1 date) (nth 0 date) (nth 2 date))))))
(or defd (current-time))))
--
2.17.1
next prev parent reply other threads:[~2019-05-28 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 13:36 Capture with date prompt defaults to yesterday Neil Jerram
2019-05-28 20:20 ` Neil Jerram [this message]
2019-06-07 12:33 ` Neil Jerram
2019-06-07 21:31 ` Nicolas Goaziou
2019-06-09 10:40 ` Neil Jerram
2019-06-10 9:22 ` Nicolas Goaziou
2019-06-11 8:53 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKuG=vuAs6-iHPzHg9LtptFZjj-DssFLfR-V7wZvxOxqEWZMdQ@mail.gmail.com' \
--to=neiljerram@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).