27.0.91; Avoid error on org-html-fontify-code

27.0.91; Avoid error on org-html-fontify-code

[pierre.techoueyres]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]


Hello Org's developpers,

Some time ago I tried to export in html form an org file containing many
src blocks and ended with the following message :

org-html-do-format-code: Buffer is read-only: #<killed buffer>

After narrowing down my file here are the steps to reproduce :

emacs -q
(require 'htmlize) ;; this is important else `org-html-fontify-code`
                   ;; will keep the wrong branch

;; open the ecm-org-src-ro.org ([1])
;; try to export as html

I've also attached a patch ([2]) to fix this.

I've also opened the bug 41641 with the sames informations.

Pierre

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ecm-org-src-ro --]
[-- Type: text/x-org, Size: 1155 bytes --]

#+title: ECM - src block read-only

   #+begin_src compilation
-*- mode: compilation; default-directory: "~/Travail/VCS/Emacs/emacs-org-mode/" -*-
Compilation started at Fri May 29 20:05:37

make -k targets 

Getting Help
============
make help           - show brief help
make targets        - ditto
make helpall        - show extended help

Build and Check
===============
make                - build Org ELisp and all documentation
make all            - ditto
make compile        - build Org ELisp files
make single         - build Org ELisp files, single Emacs per source
make autoloads      - create org-loaddefs.el to load Org in-place
make test           - build Org ELisp files and run test suite
make vanilla        - run Emacs with this Org-mode and no personal config
make config         - check main configuration
make doc            - build all documentation
make info           - build Info documentation

Installation
============
make install        - build and install Org

Full documentation on Worg
==========================
https://orgmode.org/worg/dev/org-build-system.html


Compilation finished at Fri May 29 20:05:37
   #+end_src

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-ox-html.el-Fix-read-only-error-when-export-src-bloc.patch --]
[-- Type: text/x-patch, Size: 1075 bytes --]

From c292c6bc638b6ae94bfe1fa8636b819b1d655d0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= <pierre.techoueyres@free.fr>
Date: Mon, 1 Jun 2020 12:30:04 +0200
Subject: [PATCH] ox-html.el: Fix read-only error when export src bloc

When the type of src block involve an read-only buffer (ex:
compilation mode) avoid to setup the temp buffer as read-only and
error when processing it

* lisp/ox-html.el (org-html-fontify-code): set `inhibit-read-only' to
avoid read-only temp buffer.
---
 lisp/ox-html.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index fe0a315c9..32996c2c2 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -2156,7 +2156,8 @@ org-html-fontify-code
 	  ;; htmlize
 	  (setq code
 		(let ((output-type org-html-htmlize-output-type)
-		      (font-prefix org-html-htmlize-font-prefix))
+		      (font-prefix org-html-htmlize-font-prefix)
+		      (inhibit-read-only t))
 		  (with-temp-buffer
 		    ;; Switch to language-specific mode.
 		    (funcall lang-mode)
-- 
2.26.2

Re: 27.0.91; Avoid error on org-html-fontify-code

[Kyle Meyer]

pierre.techoueyres@gmail.com writes:

> Some time ago I tried to export in html form an org file containing many
> src blocks and ended with the following message :
>
> org-html-do-format-code: Buffer is read-only: #<killed buffer>
>
> After narrowing down my file here are the steps to reproduce :
>
> emacs -q
> (require 'htmlize) ;; this is important else `org-html-fontify-code`
>                    ;; will keep the wrong branch
>
> ;; open the ecm-org-src-ro.org ([1])
> ;; try to export as html

Thanks for narrowing the issue and providing an example to trigger it
(not to mention a patch).

> Subject: [PATCH] ox-html.el: Fix read-only error when export src bloc

Looks good to me.  Applied (c631afd35), with a couple of minor tweaks to
the commit message.

Re: 27.0.91; Avoid error on org-html-fontify-code

[pierre.techoueyres]

Hi Kyle,

Kyle Meyer writes:

> pierre.techoueyres@gmail.com writes:
>
>> Some time ago I tried to export in html form an org file containing many
>> src blocks and ended with the following message :
>>
>> org-html-do-format-code: Buffer is read-only: #<killed buffer>
>>
>> After narrowing down my file here are the steps to reproduce :
>>
>> emacs -q
>> (require 'htmlize) ;; this is important else `org-html-fontify-code`
>>                    ;; will keep the wrong branch
>>
>> ;; open the ecm-org-src-ro.org ([1])
>> ;; try to export as html
>
> Thanks for narrowing the issue and providing an example to trigger it
> (not to mention a patch).
>
>> Subject: [PATCH] ox-html.el: Fix read-only error when export src bloc
>
> Looks good to me.  Applied (c631afd35), with a couple of minor tweaks to
> the commit message.

Hi kyle,
Many thanks for that. If I've well understood it's on master.  Do you
know (or guess) how long will this take to land in the next release ?

I had also open bugs #41641, may be will you close it ?

Re: 27.0.91; Avoid error on org-html-fontify-code

[Kyle Meyer]

Pierre Téchoueyres writes:

> Many thanks for that. If I've well understood it's on master.  Do you
> know (or guess) how long will this take to land in the next release ?

This month is the hope: https://orgmode.org/list/87pnaindwq.fsf@bzg.fr

> I had also open bugs #41641, may be will you close it ?

Done.