* [PATCH] ol.el: Fix confusing variable name
@ 2021-04-29 22:18 Aaron L. Zeng
2021-04-30 5:33 ` Tim Cross
0 siblings, 1 reply; 3+ messages in thread
From: Aaron L. Zeng @ 2021-04-29 22:18 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Aaron L. Zeng
* ol.el (org-link--open-help): Fix a confusing variable name. No
behavior changes.
TINYCHANGE
---
lisp/ol.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/ol.el b/lisp/ol.el
index 62ea6d2bc..617223cb5 100644
--- a/lisp/ol.el
+++ b/lisp/ol.el
@@ -1325,8 +1325,8 @@ PATH is the sexp to evaluate, as a string."
"Open a \"help\" type link.
PATH is a symbol name, as a string."
(pcase (intern path)
- ((and (pred fboundp) variable) (describe-function variable))
- ((and (pred boundp) function) (describe-variable function))
+ ((and (pred fboundp) function) (describe-function function))
+ ((and (pred boundp) variable) (describe-variable variable))
(name (user-error "Unknown function or variable: %s" name))))
(defun org-link--store-help ()
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ol.el: Fix confusing variable name
2021-04-29 22:18 [PATCH] ol.el: Fix confusing variable name Aaron L. Zeng
@ 2021-04-30 5:33 ` Tim Cross
2021-04-30 6:52 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Tim Cross @ 2021-04-30 5:33 UTC (permalink / raw)
To: emacs-orgmode
"Aaron L. Zeng" <me@bcc32.com> writes:
> * ol.el (org-link--open-help): Fix a confusing variable name. No
> behavior changes.
>
> TINYCHANGE
> ---
> lisp/ol.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ol.el b/lisp/ol.el
> index 62ea6d2bc..617223cb5 100644
> --- a/lisp/ol.el
> +++ b/lisp/ol.el
> @@ -1325,8 +1325,8 @@ PATH is the sexp to evaluate, as a string."
> "Open a \"help\" type link.
> PATH is a symbol name, as a string."
> (pcase (intern path)
> - ((and (pred fboundp) variable) (describe-function variable))
> - ((and (pred boundp) function) (describe-variable function))
> + ((and (pred fboundp) function) (describe-function function))
> + ((and (pred boundp) variable) (describe-variable variable))
> (name (user-error "Unknown function or variable: %s" name))))
>
> (defun org-link--store-help ()
Hi Aaron,
thanks for the patch. It looks straight forward, does seem to be less
confusing and in-line with the intention of the code and is only a tiny
change, so I think it should be applied.
Tim
--
Tim Cross
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-30 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-29 22:18 [PATCH] ol.el: Fix confusing variable name Aaron L. Zeng
2021-04-30 5:33 ` Tim Cross
2021-04-30 6:52 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).