From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yPPbJj+Xi2B2mQAAgWs5BA (envelope-from ) for ; Fri, 30 Apr 2021 07:35:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id JsVoIj+Xi2CObQAAbx9fmQ (envelope-from ) for ; Fri, 30 Apr 2021 05:35:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 162C81305D for ; Fri, 30 Apr 2021 07:35:59 +0200 (CEST) Received: from localhost ([::1]:44960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcLoj-00022q-2y for larch@yhetil.org; Fri, 30 Apr 2021 01:35:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcLo2-00021G-II for emacs-orgmode@gnu.org; Fri, 30 Apr 2021 01:35:14 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:44682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcLo1-0002KK-0V for emacs-orgmode@gnu.org; Fri, 30 Apr 2021 01:35:14 -0400 Received: by mail-pl1-x62f.google.com with SMTP id y1so20358782plg.11 for ; Thu, 29 Apr 2021 22:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version; bh=Uu1xo1bWIBzAt/yWOSEAuQE+Rc5scPJ6p1GsHiIMwo8=; b=MtQ+/MYp+qDJyzPSt9qANKZFGzZQEo2MxX48h1k8njVCO9iM7WOHTu/RKtfZCt3ALw u5rwNmMb3uC7Gm7hCjjN5Lx3xJm01uZfCxMWBStsZyOfSsZ7oHTZOwy3elv5581eBBaL 61+m16L2AlE0eLAbgZ3T9I//Hs8T0uhIgDb9O55n+pwnA6vqa3wfoE9ObQny9JZFLzh9 GXpmJrNDXDdkV3OdFt0Qvdc/XUrUWqIDA1wMJ3Hdu4Z1i18FkKb8igEU8iRR4JdG70MI NR4ygIVqjGHK/W8QmqCCeg474bWZVS8NgGYSPlq2jdkW1THVdpJ5tvlCf/N56aVskAwg erNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version; bh=Uu1xo1bWIBzAt/yWOSEAuQE+Rc5scPJ6p1GsHiIMwo8=; b=RXIIUt8BLuakauFrg8Ugz8/NUym9lx3iuvv5xwVLrq/SsG5Dy9c24E//Sb6ZGPPryN R+8VM+F6fKT4fA4/AG5LGJBEvYPowBbj4TLwpjC/crKBdlQpBD1vlCO75X7/D+AS4FwY xo9/ZHAyaHEbEA92jIUM3SP/PqUr02VlCpmxXxaCi+YQ3Xm4jO+S2yLTi+WNE7Kn1heP uwXyKSH4s4qmQsZ9FH6xI3EGFOlO2XtYWlzh3sGqNBRq0+0oAGRJOOMAOTI7HWSRsgOu YtXEeq4lYBocjT/M2KGaRMcYZz8s2bOCwXa6mBXePrGbc7Y+0+gdJbusWL8OBDPl0tlK Y12A== X-Gm-Message-State: AOAM531i3VWKPwnbDi8pjHXncMdBW8SyVYp+32ZqEeisGR5KMYxBsFma FowbxG/g81I9OwoQqpWnP2en7uhrans= X-Google-Smtp-Source: ABdhPJwnviMxqOLii+HKhVT6rJLyTSkhb/5NgNMElQhcICMKOsngv/Zki6P1WAOGRYI8MICMonawog== X-Received: by 2002:a17:903:2288:b029:eb:6ca4:6493 with SMTP id b8-20020a1709032288b02900eb6ca46493mr3426995plh.85.1619760911320; Thu, 29 Apr 2021 22:35:11 -0700 (PDT) Received: from tim-desktop (203-206-8-119.dyn.iinet.net.au. [203.206.8.119]) by smtp.gmail.com with ESMTPSA id q128sm823512pfb.67.2021.04.29.22.35.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 22:35:11 -0700 (PDT) References: <20210429221824.69965-1-me@bcc32.com> User-agent: mu4e 1.5.12; emacs 28.0.50 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [PATCH] ol.el: Fix confusing variable name Date: Fri, 30 Apr 2021 15:33:27 +1000 In-reply-to: <20210429221824.69965-1-me@bcc32.com> Message-ID: <87eeesibcj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=theophilusx@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619760959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Uu1xo1bWIBzAt/yWOSEAuQE+Rc5scPJ6p1GsHiIMwo8=; b=Jh7LfKnoKkBUlcAfdT/xydeAGoyMvOtsljUqTLeltmL/S5cCa1YOPP2o0XgbRLsr3t1MZh AKYGj6UJh4hBat506ujGqLRhnH24yrdcnKrQZhRCqwa3pnRY3LT9HJWEI2kRYsmI0CSuE3 aSNqeAf9wSkRhoG9RoM7ZHb0QWTHQfTPYrjDgTHKdktB7kJepw3kX009zEliw+l7/qbIJA 9v9m87iknOlBdMsmVju9zjpSdle6acF2Ue71AgI+slNmUyNeqLF/0vqUGbLZWkP2UprkQ5 u0yMSr8eMwfvWZICJ09N0T/b01CIrkGGqMK6NnX5huu5tOHl+eqHyqV5okYtzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619760959; a=rsa-sha256; cv=none; b=OIK7Tsj6czHA/OzxsdUpr8gTlVZNhtPeH2QXoQOjkUT462PKgvp4Pr91aGgBNPk32W9Y0/ J/81V5tfrxpinDTQUEuObiHpqkrBzMZL7jep5EN4arCCjq83bLcxyXLvpaIOUYuENfcdRA 1OS0t33Q6Q0rZ1mO9avVKJ26lRMvYa69KGDAzS4vxCgBzqOe9S9OLS+Rl6f9Ula7AWOVCk ACuZ7n3ra5r/KvmL36E2bAwry9M39RSXnuZkc1rd8l+1aVSyRROO1SrIOc+PSzB5VFwb7M J7ifonptuucDbWLVHADVrkdh7Gj85Pi2TQa3KbjQLmFhwHtfTT7MOcjExem4VQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="MtQ+/MYp"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="MtQ+/MYp"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 162C81305D X-Spam-Score: -3.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: e7fMQjBvrJZy "Aaron L. Zeng" writes: > * ol.el (org-link--open-help): Fix a confusing variable name. No > behavior changes. > > TINYCHANGE > --- > lisp/ol.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/ol.el b/lisp/ol.el > index 62ea6d2bc..617223cb5 100644 > --- a/lisp/ol.el > +++ b/lisp/ol.el > @@ -1325,8 +1325,8 @@ PATH is the sexp to evaluate, as a string." > "Open a \"help\" type link. > PATH is a symbol name, as a string." > (pcase (intern path) > - ((and (pred fboundp) variable) (describe-function variable)) > - ((and (pred boundp) function) (describe-variable function)) > + ((and (pred fboundp) function) (describe-function function)) > + ((and (pred boundp) variable) (describe-variable variable)) > (name (user-error "Unknown function or variable: %s" name)))) > > (defun org-link--store-help () Hi Aaron, thanks for the patch. It looks straight forward, does seem to be less confusing and in-line with the intention of the code and is only a tiny change, so I think it should be applied. Tim -- Tim Cross