From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Stig Brautaset <stig@brautaset.org>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-columns-summary-types entries can take COLLECT function
Date: Sun, 10 Sep 2017 11:21:39 +0200 [thread overview]
Message-ID: <87d16y29jw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2mv65t2in.fsf@brautaset.org> (Stig Brautaset's message of "Fri, 08 Sep 2017 20:26:56 +0100")
Hello,
Stig Brautaset <stig@brautaset.org> writes:
> I've taken a stab at adding support for allowing
> org-columns-summary-types entries to contain an optional COLLECT
> function that can be used to conditionally collect a property.
Thank you.
> Please see the included patch. I added a NEWS entry, but wasn't sure
> whether a manual entry is required.
I don't think so. Usage is quite advanced, and there's already a pointer
to the docstring.
> I added a couple simple tests, which pass, but the test immediately
> above the two I added fails when this patch is applied; I haven't been
> able to figure out why. Any help appreciated.
I fixed that. I also inserted two spaces at the end of sentences in the
docstrings.
> Subject: [PATCH] org-colview: Allow custom COLLECT functions for derived
> properties
>
> In addition to (LABEL . SUMMARIZE), org-columns-summary-types now
> accepts (LABEL SUMMARIZE COLLECT) entries. The new COLLECT function is
> called with one argument, the property being summarized.
I fixed the commit message (missing references to modified functions).
I added "TINYCHANGE" at the end of the commit.
I applied the patch.
From now on, please consider signing FSF papers if you want to provide
more patches.
Thank you!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-09-10 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 19:26 [PATCH] org-columns-summary-types entries can take COLLECT function Stig Brautaset
2017-09-10 9:21 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d16y29jw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=stig@brautaset.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).