From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org-columns-summary-types entries can take COLLECT function Date: Sun, 10 Sep 2017 11:21:39 +0200 Message-ID: <87d16y29jw.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqyQz-0005IJ-TD for emacs-orgmode@gnu.org; Sun, 10 Sep 2017 05:21:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqyQv-000801-TY for emacs-orgmode@gnu.org; Sun, 10 Sep 2017 05:21:45 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52904) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqyQv-0007yu-Me for emacs-orgmode@gnu.org; Sun, 10 Sep 2017 05:21:41 -0400 In-Reply-To: (Stig Brautaset's message of "Fri, 08 Sep 2017 20:26:56 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Stig Brautaset Cc: org mode Hello, Stig Brautaset writes: > I've taken a stab at adding support for allowing > org-columns-summary-types entries to contain an optional COLLECT > function that can be used to conditionally collect a property. Thank you. > Please see the included patch. I added a NEWS entry, but wasn't sure > whether a manual entry is required. I don't think so. Usage is quite advanced, and there's already a pointer to the docstring. > I added a couple simple tests, which pass, but the test immediately > above the two I added fails when this patch is applied; I haven't been > able to figure out why. Any help appreciated. I fixed that. I also inserted two spaces at the end of sentences in the docstrings. > Subject: [PATCH] org-colview: Allow custom COLLECT functions for derived > properties > > In addition to (LABEL . SUMMARIZE), org-columns-summary-types now > accepts (LABEL SUMMARIZE COLLECT) entries. The new COLLECT function is > called with one argument, the property being summarized. I fixed the commit message (missing references to modified functions). I added "TINYCHANGE" at the end of the commit. I applied the patch. >From now on, please consider signing FSF papers if you want to provide more patches. Thank you! Regards, -- Nicolas Goaziou